Custom formatter cleanup Fix case where displaying a class constructor generated unreadable huge ou…

Custom formatter cleanup Fix case where displaying a class constructor generated unreadable huge output. Fix case where exceptions were throw. Correct display of statics, fix indentation bugs. Add improved custom formatter test to main repro. As a drive by fix, switch hashCode to use a symbol instead of the name $identityHash as $identityHash was making custom formatter test output unstable.

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/a6a206062d603e90955c575c04b3981de6218c61

[Jacob, 2017-02-20 22:47:41]

jacobr@google.com changed reviewers:
+ vsm@google.com

[Jacob, 2017-02-20 22:47:42]

Custom formatter cleanup Fix case where displaying a class constructor generated
unreadable huge output. Fix case where exceptions were throw. Correct display of
statics, fix indentation bugs. Add improved custom formatter test to main repro.
As a drive by fix, switch hashCode to use a symbol instead of the name
$identityHash as $identityHash was making custom formatter test output unstable.

[Jacob, 2017-02-20 22:48:54]

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
(right):

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:885: var
type = getReifiedType(obj);
this is the most questionable part of the CL. Perhaps there is a simple fix to
getReifiedType so that it doesn't
return a bogus value for this case?

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/js_helper.dart (left):

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/js_helper.dart:60: int hash =
JS('int|Null', r'#.$identityHash', object);
this making the test unstable as it was hard to keep $identityHash out of the
JSON.

[vsm, 2017-02-21 14:33:00]

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/lib/js/leg...
File pkg/dev_compiler/lib/js/legacy/dart_library.js (right):

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/lib/js/leg...
pkg/dev_compiler/lib/js/legacy/dart_library.js:99:
this._library[dartLibraryName] = this._name;
Can this be moved to code_generator.dart - _emitModule perhaps?  That would make
it less legacy specific.  `this._library` should be the main export object.

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/test/brows...
File pkg/dev_compiler/test/browser/language_tests.js (left):

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/test/brows...
pkg/dev_compiler/test/browser/language_tests.js:189: 'hash_code_mangling_test':
fail,
nice :-)

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
(right):

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:885: var
type = getReifiedType(obj);
On 2017/02/20 22:48:54, Jacob wrote:
> this is the most questionable part of the CL. Perhaps there is a simple fix to
> getReifiedType so that it doesn't
> return a bogus value for this case?

I don't think this *if* clause was intended to handle types at all - just Dart
functions.

Can we do something like if (istype) return typeName?  Not sure we have a could
istype function, but we should be able to refactor dart.typeName is types.dart.

[Jacob, 2017-02-21 17:41:16]

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
(right):

https://codereview.chromium.org/2703263002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:885: var
type = getReifiedType(obj);
On 2017/02/21 14:33:00, vsm wrote:
> On 2017/02/20 22:48:54, Jacob wrote:
> > this is the most questionable part of the CL. Perhaps there is a simple fix
to
> > getReifiedType so that it doesn't
> > return a bogus value for this case?
> 
> I don't think this *if* clause was intended to handle types at all - just Dart
> functions.
> 
> Can we do something like if (istype) return typeName?  Not sure we have a
could
> istype function, but we should be able to refactor dart.typeName is
types.dart.
That is much better.
Added an isType method and returned the type name in that case.

[vsm, 2017-02-22 00:32:13]

lgtm, but see previous comment on dart_library.js on patch 1.

[Jacob, 2017-02-28 23:52:13]

Added a new trackLibraries method to rtti.dart along with code_generator
changes.
dart_library.js is now out of the business of adding the
module debugging metadata.
The debugging metadata is now also more user friendly with
proper package: and dart: names instead of mangled names.
debugger_test.dart now has working tests for module debugging as the required
information is now available when using your favorite module loader.

[vsm, 2017-03-01 00:59:27]

lgtm

https://codereview.chromium.org/2703263002/diff/60001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2703263002/diff/60001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/debugger.dart:577: // the library rather
than sorting library entries.
Run-on sentence.  :-)

[Jacob, 2017-03-01 01:32:04]

https://codereview.chromium.org/2703263002/diff/60001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2703263002/diff/60001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/debugger.dart:577: // the library rather
than sorting library entries.
On 2017/03/01 00:59:27, vsm wrote:
> Run-on sentence.  :-)

Done.

[Jacob, 2017-03-01 01:48:01]

Description was changed from

==========
Custom formatter cleanup Fix case where displaying a class constructor generated
unreadable huge output. Fix case where exceptions were throw. Correct display of
statics, fix indentation bugs. Add improved custom formatter test to main repro.
As a drive by fix, switch hashCode to use a symbol instead of the name
$identityHash as $identityHash was making custom formatter test output unstable.

BUG=
==========

to

==========
Custom formatter cleanup Fix case where displaying a class constructor generated
unreadable huge output. Fix case where exceptions were throw. Correct display of
statics, fix indentation bugs. Add improved custom formatter test to main repro.
As a drive by fix, switch hashCode to use a symbol instead of the name
$identityHash as $identityHash was making custom formatter test output unstable.

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a6a206062d603e90955c575c04b3981de6218c61
==========

[Jacob, 2017-03-01 01:48:03]

Committed patchset #5 (id:80001) manually as
a6a206062d603e90955c575c04b3981de6218c61 (presubmit successful).