chrome/browser/ui/cocoa/passwords/credential_item_button.h - Issue 2703253007: Use (i) icon and the same tooltip for the credit cards dialog and account chooser on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/credential_item_button.h

Issue 2703253007: Use (i) icon and the same tooltip for the credit cards dialog and account chooser on Mac. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/passwords/credential_item_button.h

diff --git a/chrome/browser/ui/cocoa/passwords/credential_item_button.h b/chrome/browser/ui/cocoa/passwords/credential_item_button.h

index 648e77aee4afc5cc613a750455f9619ccd6af3c0..a4619ec10191cbb8b280c84ed58fec673d33beae 100644

--- a/chrome/browser/ui/cocoa/passwords/credential_item_button.h

+++ b/chrome/browser/ui/cocoa/passwords/credential_item_button.h

@@ -22,6 +22,11 @@ struct PasswordForm;

- (id)initWithFrame:(NSRect)frameRect

backgroundColor:(NSColor*)backgroundColor

hoverColor:(NSColor*)hoverColor;

+// Adds (i) icon with a tooltip to the view.

+- (NSView*)enableIcon:(NSString*)tooltip;

groby-ooo-7-16 2017/02/23 00:22:49 Shouldn't this be called something like "addInfoIc

nsphu.cnht 2017/02/24 15:09:15 Done.

vasilii 2017/02/24 17:53:01 Done.

+// Returns an image to be used as a default avatar.

+ (NSImage*)defaultAvatar;

@end