components/resources/autofill_scaled_resources.grdp - Issue 2703253007: Use (i) icon and the same tooltip for the credit cards dialog and account chooser on Mac.

Side by Side Diff: components/resources/autofill_scaled_resources.grdp

Issue 2703253007: Use (i) icon and the same tooltip for the credit cards dialog and account chooser on Mac. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/passwords/credential_item_button.mm ('K') | « chrome/browser/ui/cocoa/passwords/credential_item_button.mm ('k') | no next file » | no next file with comments »

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <grit-part>	2 <grit-part>

3 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_AMEX" file="autofi ll/amex.png" />	3 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_AMEX" file="autofi ll/amex.png" />

4 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_DINERS" file="auto fill/diners.png" />	4 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_DINERS" file="auto fill/diners.png" />

5 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_DISCOVER" file="au tofill/discover.png" />	5 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_DISCOVER" file="au tofill/discover.png" />

6 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_GENERIC" file="aut ofill/cc-generic.png" />	6 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_GENERIC" file="aut ofill/cc-generic.png" />

7 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_JCB" file="autofil l/jcb.png" />	7 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_JCB" file="autofil l/jcb.png" />

8 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_MASTERCARD" file=" autofill/mastercard.png" />	8 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_MASTERCARD" file=" autofill/mastercard.png" />

9 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_MIR" file="autofil l/mir.png" />	9 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_MIR" file="autofil l/mir.png" />

10 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_VISA" file="autofi ll/visa.png" />	10 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_VISA" file="autofi ll/visa.png" />

(...skipping 18 matching lines...) Expand all Loading...
29 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_MASTERCARD" file=" autofill/pr_mc.png" />	29 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_MASTERCARD" file=" autofill/pr_mc.png" />

30 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_MIR" file="autofil l/pr_mir.png" />	30 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_MIR" file="autofil l/pr_mir.png" />

31 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_UNIONPAY" file="au tofill/pr_unionpay.png" />	31 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_UNIONPAY" file="au tofill/pr_unionpay.png" />

32 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_VISA" file="autofi ll/pr_visa.png" />	32 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_VISA" file="autofi ll/pr_visa.png" />

33	33

34 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT" file="au tofill/credit_card_cvc_hint.png" />	34 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT" file="au tofill/credit_card_cvc_hint.png" />

35 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT_AMEX" fil e="autofill/credit_card_cvc_hint_amex.png" />	35 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT_AMEX" fil e="autofill/credit_card_cvc_hint_amex.png" />

36 <if expr="is_ios or is_android">	36 <if expr="is_ios or is_android">

37 <structure type="chrome_scaled_image" name="IDR_INFOBAR_AUTOFILL_CC" file="a utofill/infobar_autofill_cc.png" />	37 <structure type="chrome_scaled_image" name="IDR_INFOBAR_AUTOFILL_CC" file="a utofill/infobar_autofill_cc.png" />

38 </if>	38 </if>

39 <if expr="is_macosx or is_ios">	39 <if expr="is_ios">

40 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON" file= "autofill/autofill_tooltip_icon.png" />	40 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON" file= "autofill/autofill_tooltip_icon.png" />
	groby-ooo-7-16 2017/02/23 00:22:49 Any chance to make this an SVG resource? Any chance to make this an SVG resource? nsphu.cnht 2017/02/24 15:09:15 Acknowledged. Show quoted text On 2017/02/23 00:22:49, groby wrote: > Any chance to make this an SVG resource? Acknowledged. nsphu.cnht 2017/02/24 15:09:15 Acknowledged. Show quoted text On 2017/02/23 00:22:49, groby wrote: > Any chance to make this an SVG resource? Acknowledged. nsphu.cnht 2017/02/24 15:09:15 Done. Show quoted text On 2017/02/23 00:22:49, groby wrote: > Any chance to make this an SVG resource? >690920 Done. vasilii 2017/02/24 17:53:01 Currently vector_icons/ isn't compiled on iOS. Thu Show quoted text On 2017/02/23 00:22:49, groby wrote: > Any chance to make this an SVG resource? Currently vector_icons/ isn't compiled on iOS. Thus, not in this CL. In general I can ask the Bling folks if you want.
41 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON_H" fil e="autofill/autofill_tooltip_icon_hover.png" />	41 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON_H" fil e="autofill/autofill_tooltip_icon_hover.png" />

42 </if>	42 </if>

43 </grit-part>	43 </grit-part>

OLD	NEW