Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: pkg/analyzer/lib/src/context/builder.dart

Issue 2703253006: Turn off `strong_mode_down_cast_composite` warnings by default in Flutter projects.
Patch Set: Remove newline. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/context/source.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/context/builder.dart
diff --git a/pkg/analyzer/lib/src/context/builder.dart b/pkg/analyzer/lib/src/context/builder.dart
index 2d8b0f14a5ef548f6428bd5219fb070827cc96ab..62b700d3234b2711f419df0ffb1ca7e76fe334b6 100644
--- a/pkg/analyzer/lib/src/context/builder.dart
+++ b/pkg/analyzer/lib/src/context/builder.dart
@@ -388,7 +388,7 @@ class ContextBuilder {
// Search for the default analysis options
Source source;
// TODO(danrubel) determine if bazel or gn project depends upon flutter
- if (workspace.hasFlutterDependency) {
+ if (sourceFactory.hasFlutterDependency) {
source =
sourceFactory.forUri('package:flutter/analysis_options_user.yaml');
}
@@ -730,10 +730,6 @@ class _BasicWorkspace extends Workspace {
_BasicWorkspace._(this.provider, this.root, this._builder);
@override
- // Alternately, we could check the pubspec for "sdk: flutter"
- bool get hasFlutterDependency => packageMap.containsKey('flutter');
-
- @override
Map<String, List<Folder>> get packageMap {
_packageMap ??= _builder.convertPackagesToMap(packages);
return _packageMap;
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/context/source.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698