Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 270323003: Extracted UsbConfigDescriptor, UsbInterfaceDescriptor and helper classes (Closed)

Created:
6 years, 7 months ago by Dmitry Zvorygin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Extracted UsbConfigDescriptor, UsbInterfaceDescriptor and helper classes as interfaces. BUG=367094 R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269767

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -287 lines) Patch
M components/usb_service.gypi View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/usb_service/usb_device_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/usb_service/usb_device_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/usb_service/usb_interface.h View 5 chunks +32 lines, -69 lines 0 comments Download
D components/usb_service/usb_interface.cc View 1 chunk +0 lines, -174 lines 0 comments Download
A components/usb_service/usb_interface_impl.h View 1 chunk +118 lines, -0 lines 0 comments Download
A + components/usb_service/usb_interface_impl.cc View 5 chunks +36 lines, -42 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Dmitry Zvorygin
Please take a look.
6 years, 7 months ago (2014-05-08 11:38:53 UTC) #1
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/270323003/diff/1/components/usb_service/usb_interface.h File components/usb_service/usb_interface.h (right): https://codereview.chromium.org/270323003/diff/1/components/usb_service/usb_interface.h#newcode38 components/usb_service/usb_interface.h:38: class USB_SERVICE_EXPORT UsbEndpointDescriptor Please don't feel obligated to ...
6 years, 7 months ago (2014-05-08 12:57:20 UTC) #2
Dmitry Zvorygin
The CQ bit was checked by zvorygin@chromium.org
6 years, 7 months ago (2014-05-08 12:58:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/270323003/1
6 years, 7 months ago (2014-05-08 13:01:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 13:52:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 13:57:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/2435) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66478) linux_chromium_chromeos_clang_dbg ...
6 years, 7 months ago (2014-05-08 13:57:08 UTC) #7
Dmitry Zvorygin
The CQ bit was checked by zvorygin@chromium.org
6 years, 7 months ago (2014-05-08 14:49:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/270323003/1
6 years, 7 months ago (2014-05-08 14:54:21 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 15:35:08 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 15:40:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/2468) android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/152278) chromium_presubmit ...
6 years, 7 months ago (2014-05-08 15:40:44 UTC) #12
Dmitry Zvorygin
6 years, 7 months ago (2014-05-12 11:35:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 manually as r269767 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698