chrome/browser/notifications/platform_notification_service_unittest.cc - Issue 2703213004: Migrate extension notifications to the new NotificationDisplayService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_unittest.cc

Issue 2703213004: Migrate extension notifications to the new NotificationDisplayService (Closed)

Patch Set: Miguel's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/notifications/notifications_api.cc ('K') | « chrome/browser/notifications/notification_display_service.h ('k') | chrome/browser/notifications/stub_notification_display_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_unittest.cc

diff --git a/chrome/browser/notifications/platform_notification_service_unittest.cc b/chrome/browser/notifications/platform_notification_service_unittest.cc

index f26cae46a79145e3165d0a2cefcc3cb3afb25ba0..7d5bad8b8515d26ff136a736ba250d0c216f487a 100644

--- a/chrome/browser/notifications/platform_notification_service_unittest.cc

+++ b/chrome/browser/notifications/platform_notification_service_unittest.cc

@@ -96,6 +96,8 @@ class PlatformNotificationServiceTest : public testing::Test {

std::unique_ptr<NotificationPlatformBridge> notification_bridge =

base::MakeUnique<StubNotificationPlatformBridge>();

+ // TODO(peter): These tests should use the NotificationDisplayService, which

+ // will allow the StubNotificationPlatformBridge to be removed.

TestingBrowserProcess::GetGlobal()->SetNotificationUIManager(

std::move(ui_manager));

TestingBrowserProcess::GetGlobal()->SetNotificationPlatformBridge(