Migrate extension notifications to the new NotificationDisplayService

chrome/browser/notifications/platform_notification_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/macros.h"
@@ skipping 80 matching lines @@
   void SetUp() override {
     profile_manager_ = base::MakeUnique<TestingProfileManager>(
         TestingBrowserProcess::GetGlobal());
     ASSERT_TRUE(profile_manager_->SetUp());
     profile_ = profile_manager_->CreateTestingProfile("Miguel");
     std::unique_ptr<NotificationUIManager> ui_manager =
         base::MakeUnique<StubNotificationUIManager>();
     std::unique_ptr<NotificationPlatformBridge> notification_bridge =
         base::MakeUnique<StubNotificationPlatformBridge>();
 
+    // TODO(peter): These tests should use the NotificationDisplayService, which
+    // will allow the StubNotificationPlatformBridge to be removed.
     TestingBrowserProcess::GetGlobal()->SetNotificationUIManager(
         std::move(ui_manager));
     TestingBrowserProcess::GetGlobal()->SetNotificationPlatformBridge(
         std::move(notification_bridge));
   }
 
   void TearDown() override {
     profile_manager_.reset();
     TestingBrowserProcess::DeleteInstance();
   }
@@ skipping 62 matching lines @@
   }
 
  private:
   NotificationDisplayService* display_service() const {
     return NotificationDisplayServiceFactory::GetForProfile(profile_);
   }
 
   std::unique_ptr<TestingProfileManager> profile_manager_;
   TestingProfile* profile_;
   content::TestBrowserThreadBundle thread_bundle_;
   mutable std::unique_ptr<std::set<std::string>> displayed_notifications_;

[dewittj, 2017/04/10 17:51:23]

nit: const/mutable dance here seems like overkill.  Feel free to disregard this
comment.

[Peter Beverloo, 2017/04/11 00:39:21]

No, you're right. Discussed this with Miguel today and we're going to get rid of
it.

 };
 
 TEST_F(PlatformNotificationServiceTest, DisplayPageDisplayedEvent) {
   auto* delegate = CreateSimplePageNotification();
 
   EXPECT_EQ(1u, GetNotificationCount());
   EXPECT_TRUE(delegate->displayed());
 }
 
 TEST_F(PlatformNotificationServiceTest, DisplayPageCloseClosure) {
@@ skipping 229 matching lines @@
       profile(),
       GURL() /* service_worker_scope */,
       GURL("chrome-extension://honijodknafkokifofgiaalefdiedpko/main.html"),
       notification_data, NotificationResources(),
       new MockNotificationDelegate("hello"));
   EXPECT_EQ("NotificationTest",
             base::UTF16ToUTF8(notification.context_message()));
 }
 
 #endif  // BUILDFLAG(ENABLE_EXTENSIONS)