Migrate extension notifications to the new NotificationDisplayService

chrome/browser/notifications/platform_notification_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include <utility>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 78 matching lines @@
   void SetUp() override {
     profile_manager_ = base::MakeUnique<TestingProfileManager>(
         TestingBrowserProcess::GetGlobal());
     ASSERT_TRUE(profile_manager_->SetUp());
     profile_ = profile_manager_->CreateTestingProfile("Miguel");
     std::unique_ptr<NotificationUIManager> ui_manager =
         base::MakeUnique<StubNotificationUIManager>();
     std::unique_ptr<NotificationPlatformBridge> notification_bridge =
         base::MakeUnique<StubNotificationPlatformBridge>();
 
+    // TODO(peter): These tests should use the NotificationDisplayService, which

[Miguel Garcia, 2017/02/21 10:56:44]

I'd like to discuss this offline (and will not block the CL) I kind of like the
idea of testing the whole PlatformNotificationService -> Bridge since (as you
know) I consider the bridge and the display service very close together (they
are not the same class because the latter needs to be a singleton while the
former is keyed by profile).

[Peter Beverloo, 2017/02/21 17:23:50]

Sure. In my mind, NotificationDisplayService will provide basic functionality
(e.g. attaching handlers), with the {Native,MessageCenter}DisplayServices
extending it for targeted functionality. The Stub implementation would use the
common functionality too, so we don't actually lose any test coverage.

+    // will allow the StubNotificationPlatformBridge to be removed.
     TestingBrowserProcess::GetGlobal()->SetNotificationUIManager(
         std::move(ui_manager));
     TestingBrowserProcess::GetGlobal()->SetNotificationPlatformBridge(
         std::move(notification_bridge));
   }
 
   void TearDown() override {
     profile_manager_.reset();
     TestingBrowserProcess::DeleteInstance();
   }
@@ skipping 327 matching lines @@
       profile(),
       GURL() /* service_worker_scope */,
       GURL("chrome-extension://honijodknafkokifofgiaalefdiedpko/main.html"),
       notification_data, NotificationResources(),
       new MockNotificationDelegate("hello"));
   EXPECT_EQ("NotificationTest",
             base::UTF16ToUTF8(notification.context_message()));
 }
 
 #endif  // BUILDFLAG(ENABLE_EXTENSIONS)