chrome/browser/extensions/api/notifications/extension_notification_handler.cc - Issue 2703213004: Migrate extension notifications to the new NotificationDisplayService

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/notifications/extension_notification_handler.cc

Issue 2703213004: Migrate extension notifications to the new NotificationDisplayService (Closed)

Patch Set: another rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/extensions/api/notifications/extension_notification_han dler.h"

	6

	7 #include "base/logging.h"

	8

	9 ExtensionNotificationHandler::ExtensionNotificationHandler() = default;

	10

	11 ExtensionNotificationHandler::~ExtensionNotificationHandler() = default;

	12

	13 void ExtensionNotificationHandler::OpenSettings(Profile* profile) {

	14 // Extension notifications don't display a settings button.

	15 NOTREACHED();
	Devlin 2017/04/10 21:23:55 What is this class used for? What is this class used for? Peter Beverloo 2017/04/10 23:30:06 Notifications still have delegates, but we'd like Show quoted text On 2017/04/10 21:23:55, Devlin wrote: > What is this class used for? Notifications still have delegates, but we'd like to get rid of those in the mid-term as they make a hard assumption that the browser process will outlive the notification. NonPersistentNotificationHandler (the parent class) provides the necessary forwarding behaviour.
	16 }

OLD	NEW