Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: chrome/app/chrome_breakpad_client_mac.mm

Issue 27031002: Move checking of configured policy on win to breakpad client (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_breakpad_client.cc ('k') | components/breakpad/breakpad_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_breakpad_client_mac.mm
diff --git a/chrome/app/chrome_breakpad_client_mac.mm b/chrome/app/chrome_breakpad_client_mac.mm
index e841440b37143ea809f3cb3d2761abce5ca6ce0d..da6bc4452cc349c1cc1df6f7d8ec8063e636ef34 100644
--- a/chrome/app/chrome_breakpad_client_mac.mm
+++ b/chrome/app/chrome_breakpad_client_mac.mm
@@ -42,15 +42,18 @@ void ChromeBreakpadClient::InstallAdditionalFilters(BreakpadRef breakpad) {
#endif
}
-bool ChromeBreakpadClient::ReportingIsEnforcedByPolicy() {
+bool ChromeBreakpadClient::ReportingIsEnforcedByPolicy(bool* breakpad_enabled) {
base::ScopedCFTypeRef<CFStringRef> key(
base::SysUTF8ToCFStringRef(policy::key::kMetricsReportingEnabled));
Boolean key_valid;
Boolean metrics_reporting_enabled = CFPreferencesGetAppBooleanValue(key,
kCFPreferencesCurrentApplication, &key_valid);
- return key_valid &&
- CFPreferencesAppValueIsForced(key, kCFPreferencesCurrentApplication) &&
- metrics_reporting_enabled;
+ if (key_valid &&
+ CFPreferencesAppValueIsForced(key, kCFPreferencesCurrentApplication)) {
+ *breakpad_enabled = metrics_reporting_enabled;
+ return true;
+ }
+ return false;
}
} // namespace chrome
« no previous file with comments | « chrome/app/chrome_breakpad_client.cc ('k') | components/breakpad/breakpad_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698