Move checking of configured policy on win to breakpad client

chrome/app/breakpad_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/breakpad_win.h"
 
 #include <shellapi.h>
 #include <tchar.h>
 #include <userenv.h>
 #include <windows.h>
@@ skipping 15 matching lines @@
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/metro.h"
 #include "base/win/pe_image.h"
 #include "base/win/registry.h"
 #include "base/win/win_util.h"
 #include "breakpad/src/client/windows/handler/exception_handler.h"
 #include "chrome/app/hard_error_handler_win.h"
 #include "components/breakpad/breakpad_client.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/result_codes.h"
-#include "policy/policy_constants.h"
 #include "sandbox/win/src/nt_internals.h"
 #include "sandbox/win/src/sidestep/preamble_patcher.h"
 
 // userenv.dll is required for GetProfileType().
 #pragma comment(lib, "userenv.lib")
 
 #pragma intrinsic(_AddressOfReturnAddress)
 #pragma intrinsic(_ReturnAddress)
 
 namespace breakpad_win {
@@ skipping 161 matching lines @@
     size_t chunk_length = std::min(kChunkSize, path.size() - chunk_start);
 
     g_custom_entries->push_back(google_breakpad::CustomInfoEntry(
         base::StringPrintf(L"plugin-path-chunk-%i", chunk_index + 1).c_str(),
         path.substr(chunk_start, chunk_length).c_str()));
 
     chunk_start += chunk_length;
   }
 }
 
-// Determine whether configuration management allows loading the crash reporter.
-// Since the configuration management infrastructure is not initialized at this
-// point, we read the corresponding registry key directly. The return status
-// indicates whether policy data was successfully read. If it is true, |result|
-// contains the value set by policy.
-static bool MetricsReportingControlledByPolicy(bool* result) {
-  string16 key_name = UTF8ToUTF16(policy::key::kMetricsReportingEnabled);
-  DWORD value = 0;
-  base::win::RegKey hklm_policy_key(HKEY_LOCAL_MACHINE,
-                                    policy::kRegistryChromePolicyKey, KEY_READ);
-  if (hklm_policy_key.ReadValueDW(key_name.c_str(), &value) == ERROR_SUCCESS) {
-    *result = value != 0;
-    return true;
-  }
-
-  base::win::RegKey hkcu_policy_key(HKEY_CURRENT_USER,
-                                    policy::kRegistryChromePolicyKey, KEY_READ);
-  if (hkcu_policy_key.ReadValueDW(key_name.c_str(), &value) == ERROR_SUCCESS) {
-    *result = value != 0;
-    return true;
-  }
-
-  return false;
-}
-
 // Appends the breakpad dump path to |g_custom_entries|.
 void SetBreakpadDumpPath() {
   DCHECK(g_custom_entries);
   base::FilePath crash_dumps_dir_path;
   if (breakpad::GetBreakpadClient()->GetAlternativeCrashDumpLocation(
           &crash_dumps_dir_path)) {
     g_custom_entries->push_back(google_breakpad::CustomInfoEntry(
         L"breakpad-dump-location", crash_dumps_dir_path.value().c_str()));
   }
 }
@@ skipping 70 matching lines @@
   if (type == L"plugin" || type == L"ppapi") {
     std::wstring plugin_path =
         CommandLine::ForCurrentProcess()->GetSwitchValueNative("plugin-path");
     if (!plugin_path.empty())
       SetPluginPath(plugin_path);
   }
 
   // Check whether configuration management controls crash reporting.
   bool crash_reporting_enabled = true;
   bool controlled_by_policy =
-      MetricsReportingControlledByPolicy(&crash_reporting_enabled);
+      breakpad::GetBreakpadClient()->ReportingIsEnforcedByPolicy(
+          &crash_reporting_enabled);
   const CommandLine& command = *CommandLine::ForCurrentProcess();
   bool use_crash_service =
       !controlled_by_policy &&
       (command.HasSwitch(switches::kNoErrorDialogs) ||
        breakpad::GetBreakpadClient()->IsRunningUnattended());
   if (use_crash_service)
     SetBreakpadDumpPath();
 
   // Create space for dynamic ad-hoc keys. The names and values are set using
   // the API defined in base/debug/crash_logging.h.
@@ skipping 301 matching lines @@
 static void InitPipeNameEnvVar(bool is_per_user_install) {
   scoped_ptr<base::Environment> env(base::Environment::Create());
   if (env->HasVar(kPipeNameVar)) {
     // The Breakpad pipe name is already configured: nothing to do.
     return;
   }
 
   // Check whether configuration management controls crash reporting.
   bool crash_reporting_enabled = true;
   bool controlled_by_policy =
-      MetricsReportingControlledByPolicy(&crash_reporting_enabled);
+      breakpad::GetBreakpadClient()->ReportingIsEnforcedByPolicy(
+          &crash_reporting_enabled);
 
   const CommandLine& command = *CommandLine::ForCurrentProcess();
   bool use_crash_service =
       !controlled_by_policy &&
       (command.HasSwitch(switches::kNoErrorDialogs) ||
        breakpad::GetBreakpadClient()->IsRunningUnattended());
 
   std::wstring pipe_name;
   if (use_crash_service) {
     // Crash reporting is done by crash_service.exe.
@@ skipping 137 matching lines @@
       // Initialize the hook TerminateProcess to catch unexpected exits.
       InitTerminateProcessHooks();
     }
 #endif
   }
 }
 
 void InitDefaultCrashCallback(LPTOP_LEVEL_EXCEPTION_FILTER filter) {
   previous_filter = SetUnhandledExceptionFilter(filter);
 }