Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

Issue 2703093002: Add metrics for tracking subresource filter activation suppression. (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
index 13f70d845fc7443d07374a9d96094ff0bd167969..32de069d547e22496ea34b0bc4a45c170dd139c8 100644
--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
@@ -5,8 +5,14 @@
#include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
+#include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"
#include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
+using subresource_filter::ContentSubresourceFilterDriverFactory;
+
+using ActivationDecision = subresource_filter::
+ ContentSubresourceFilterDriverFactory::ActivationDecision;
+
namespace internal {
const char kHistogramSubresourceFilterFirstContentfulPaint[] =
@@ -47,8 +53,34 @@ const char kHistogramSubresourceFilterCacheBytes[] =
const char kHistogramSubresourceFilterCount[] =
"PageLoad.Clients.SubresourceFilter.Count";
+const char kHistogramSubresourceFilterActivationDecision[] =
+ "PageLoad.Clients.SubresourceFilter.ActivationDecision";
+const char kHistogramSubresourceFilterActivationDecisionReload[] =
+ "PageLoad.Clients.SubresourceFilter.ActivationDecision.LoadType.Reload";
+
} // namespace internal
+namespace {
+
+void LogActivationDecisionMetrics(content::NavigationHandle* navigation_handle,
+ ActivationDecision decision) {
+ UMA_HISTOGRAM_ENUMERATION(
+ internal::kHistogramSubresourceFilterActivationDecision,
+ static_cast<int>(decision),
+ static_cast<int>(ActivationDecision::ACTIVATION_DECISION_MAX));
+
+ if (ContentSubresourceFilterDriverFactory::NavigationIsPageReload(
+ navigation_handle->GetURL(), navigation_handle->GetReferrer(),
+ navigation_handle->GetPageTransition())) {
+ UMA_HISTOGRAM_ENUMERATION(
+ internal::kHistogramSubresourceFilterActivationDecisionReload,
+ static_cast<int>(decision),
+ static_cast<int>(ActivationDecision::ACTIVATION_DECISION_MAX));
+ }
+}
+
+} // namespace
+
page_load_metrics::PageLoadMetricsObserver::ObservePolicy
SubresourceFilterMetricsObserver::FlushMetricsOnAppEnterBackground(
const page_load_metrics::PageLoadTiming& timing,
@@ -62,6 +94,19 @@ SubresourceFilterMetricsObserver::FlushMetricsOnAppEnterBackground(
return STOP_OBSERVING;
}
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+SubresourceFilterMetricsObserver::OnCommit(
+ content::NavigationHandle* navigation_handle) {
+ const auto* subres_filter =
+ ContentSubresourceFilterDriverFactory::FromWebContents(
+ navigation_handle->GetWebContents());
+ if (subres_filter)
+ LogActivationDecisionMetrics(
+ navigation_handle,
+ subres_filter->GetActivationDecisionForLastCommittedPageLoad());
+ return CONTINUE_OBSERVING;
+}
+
void SubresourceFilterMetricsObserver::OnComplete(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {

Powered by Google App Engine
This is Rietveld 408576698