Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 270303004: Revert of Add blink-side plumbing for ServiceWorker -> Document postMessage (1/3) (Closed)

Created:
6 years, 7 months ago by loislo
Modified:
6 years, 7 months ago
CC:
blink-reviews, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, falken, dglazkov+blink, horo+watch_chromium.org, alecflett+watch_chromium.org, michaeln
Visibility:
Public.

Description

Revert of Add blink-side plumbing for ServiceWorker -> Document postMessage (1/3) (https://codereview.chromium.org/263143004/) Reason for revert: Speculative revert in order of fixing crashes in content_browsertests Original issue's description: > Add blink-side plumbing for ServiceWorker -> Document postMessage > > - Initialize NavigatorServiceWorker and ServiceWorkerContainer earlier, right after a document is available (for Documents) > - Add public interfaces: > -- WebServiceWorkerContextClient.postMessageToClient() > -- WebServiceWorkerProviderClient.dispatchMessageEvent() > > This is the first patch for postMessage plumbing: > 1/3: THIS PATCH > 2/3: https://codereview.chromium.org/246023007/ (chromium) > 3/3: https://codereview.chromium.org/264233003/ (blink, adds Layout test) > > BUG=366063 > TEST=to be added after chromium-side change is landed > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173495 TBR=jsbell@chromium.org,jochen@chromium.org,kinuko@chromium.org NOTREECHECKS=true NOTRY=true BUG=366063 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -43 lines) Patch
M Source/modules/serviceworkers/NavigatorServiceWorker.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M public/platform/WebServiceWorkerProviderClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
loislo
Created Revert of Add blink-side plumbing for ServiceWorker -> Document postMessage (1/3)
6 years, 7 months ago (2014-05-07 13:25:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/270303004/1
6 years, 7 months ago (2014-05-07 13:27:20 UTC) #2
commit-bot: I haz the power
Change committed as 173523
6 years, 7 months ago (2014-05-07 13:27:44 UTC) #3
kinuko
On 2014/05/07 13:27:44, I haz the power (commit-bot) wrote: > Change committed as 173523 Could ...
6 years, 7 months ago (2014-05-07 14:14:36 UTC) #4
loislo
On 2014/05/07 14:14:36, kinuko wrote: > On 2014/05/07 13:27:44, I haz the power (commit-bot) wrote: ...
6 years, 7 months ago (2014-05-07 14:24:50 UTC) #5
kinuko
6 years, 7 months ago (2014-05-07 14:35:22 UTC) #6
Message was sent while issue was closed.
On 2014/05/07 14:24:50, loislo wrote:
> On 2014/05/07 14:14:36, kinuko wrote:
> > On 2014/05/07 13:27:44, I haz the power (commit-bot) wrote:
> > > Change committed as 173523
> > 
> > Could you paste a link to the failure bot?
> 
>
http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/2962...
> 
> and it could be easily reproduced on a linux box. I did that on my corp linux

Ok thanks, I just found the same log. Will look into it.

Powered by Google App Engine
This is Rietveld 408576698