ios/chrome/browser/favicon/favicon_service_factory.h - Issue 2703003002: Set null testing Favicon factories on iOS too

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/favicon/favicon_service_factory.h

Issue 2703003002: Set null testing Favicon factories on iOS too (Closed)

Patch Set: Revert traces. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_	5 #ifndef IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_

6 #define IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_	6 #define IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_

7	7

8 #include <memory>	8 #include <memory>

9	9

10 #include "base/macros.h"	10 #include "base/macros.h"

(...skipping 25 matching lines...) Expand all Loading...
36	36

37 private:	37 private:

38 friend struct base::DefaultSingletonTraits<FaviconServiceFactory>;	38 friend struct base::DefaultSingletonTraits<FaviconServiceFactory>;

39	39

40 FaviconServiceFactory();	40 FaviconServiceFactory();

41 ~FaviconServiceFactory() override;	41 ~FaviconServiceFactory() override;

42	42

43 // BrowserStateKeyedServiceFactory implementation.	43 // BrowserStateKeyedServiceFactory implementation.

44 std::unique_ptr<KeyedService> BuildServiceInstanceFor(	44 std::unique_ptr<KeyedService> BuildServiceInstanceFor(

45 web::BrowserState* context) const override;	45 web::BrowserState* context) const override;

	46 bool ServiceIsNULLWhileTesting() const override;
	noyau (Ping after 24h) 2017/02/21 12:28:16 I hate things added to public APIs to use only for I hate things added to public APIs to use only for tests... mastiz 2017/02/21 12:37:10 Agreed :-/ Show quoted text On 2017/02/21 12:28:16, noyau wrote: > I hate things added to public APIs to use only for tests... Agreed :-/
46	47

47 DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory);	48 DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory);

48 };	49 };

49	50

50 } // namespace ios	51 } // namespace ios

51	52

52 #endif // IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_	53 #endif // IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_

OLD	NEW

« no previous file with comments | « no previous file | ios/chrome/browser/favicon/favicon_service_factory.cc » ('j') | no next file with comments »