Restoring notifications on startup

chrome/browser/resources/google_now/cards.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Show/hide trigger in a card.
  *
  * @typedef {{
@@ skipping 36 matching lines @@
  *   hideTime: number=,
  *   version: number,
  *   previousVersion: number=
  * }}
  */
 var CardCreateInfo;
 
 /**
  * Names for tasks that can be created by the this file.
  */
+var SHOW_CARD_TASK_NAME = 'show-card';
 var CLEAR_CARD_TASK_NAME = 'clear-card';
 
 /**
  * Builds an object to manage notification card set.
  * @return {Object} Card set interface.
  */
 function buildCardSet() {
   var cardShowPrefix = 'card-show-';
   var cardHidePrefix = 'card-hide-';
 
@@ skipping 15 matching lines @@
   /**
    * Shows a notification.
    * @param {string} cardId Card ID.
    * @param {CardCreateInfo} cardCreateInfo Google Now card represented as a set
    *     of parameters for showing a Chrome notification.
    */
   function showNotification(cardId, cardCreateInfo) {
     console.log('cardManager.showNotification ' + cardId + ' ' +
                 JSON.stringify(cardCreateInfo));
 
+    if (cardCreateInfo.hideTime <= Date.now()) {
+      console.log('cardManager.showNotification ' + cardId + ': expired');
+      // Card has expired. Schedule hiding to delete asociated information.
+      scheduleHiding(cardId, cardCreateInfo.hideTime);
+      return;
+    }
+
     if (cardCreateInfo.previousVersion !== cardCreateInfo.version) {
       // Delete a notification with the specified id if it already exists, and
       // then create a notification.
       instrumented.notifications.create(
           cardId,
           cardCreateInfo.notification,
           function(newNotificationId) {
             if (!newNotificationId || chrome.runtime.lastError) {
               var errorMessage = chrome.runtime.lastError &&
-                                  chrome.runtime.lastError.message;
+                                 chrome.runtime.lastError.message;
               console.error('notifications.create: ID=' + newNotificationId +
                             ', ERROR=' + errorMessage);
               return;
             }
 
             scheduleHiding(cardId, cardCreateInfo.hideTime);
           });
     } else {
       // Update existing notification.
       instrumented.notifications.update(
           cardId,
           cardCreateInfo.notification,
           function(wasUpdated) {
             if (!wasUpdated || chrome.runtime.lastError) {
               var errorMessage = chrome.runtime.lastError &&
-                                  chrome.runtime.lastError.message;
+                                 chrome.runtime.lastError.message;
               console.error('notifications.update: UPDATED=' + wasUpdated +
                             ', ERROR=' + errorMessage);
               return;
             }
 
             scheduleHiding(cardId, cardCreateInfo.hideTime);
           });
     }
   }
 
@@ skipping 76 matching lines @@
             chrome.storage.local.set(items);
           });
     }
   }
 
   instrumented.alarms.onAlarm.addListener(function(alarm) {
     console.log('cardManager.onAlarm ' + JSON.stringify(alarm));
 
     if (alarm.name.indexOf(cardShowPrefix) == 0) {
       // Alarm to show the card.
-      var cardId = alarm.name.substring(cardShowPrefix.length);
-      instrumented.storage.local.get('notificationsData', function(items) {
-        console.log('cardManager.onAlarm.get ' + JSON.stringify(items));
-        if (!items || !items.notificationsData)
-          return;
-        var notificationData = items.notificationsData[cardId];
-        if (!notificationData)
-          return;
+      tasks.add(SHOW_CARD_TASK_NAME, function() {

[robliao, 2013/10/14 21:05:31]

Why is this going to a task?

[vadimt, 2013/10/14 23:51:57]

It manipulates with storage and can create notifications. Polling for cards and
restoring cards compete for same resources. So, task is a good idea.

+        var cardId = alarm.name.substring(cardShowPrefix.length);
+        instrumented.storage.local.get('notificationsData', function(items) {
+          console.log('cardManager.onAlarm.get ' + JSON.stringify(items));
+          if (!items || !items.notificationsData)
+            return;
+          var notificationData = items.notificationsData[cardId];
+          if (!notificationData)
+            return;
 
-        showNotification(cardId, notificationData.cardCreateInfo);
+          showNotification(cardId, notificationData.cardCreateInfo);
+        });
       });
     } else if (alarm.name.indexOf(cardHidePrefix) == 0) {
       // Alarm to hide the card.
       tasks.add(CLEAR_CARD_TASK_NAME, function() {
         var cardId = alarm.name.substring(cardHidePrefix.length);
         clear(cardId, true);
       });
     }
   });
 
   return {
     update: update,
     clear: clear
   };
 }