chrome/browser/profile_resetter/automatic_profile_resetter_mementos.cc - Issue 27030002: Added collecting of data to be fed to the JTL interpreter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profile_resetter/automatic_profile_resetter_mementos.cc

Issue 27030002: Added collecting of data to be fed to the JTL interpreter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments from vasilii@. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc ('K') | « chrome/browser/profile_resetter/automatic_profile_resetter_factory.cc ('k') | chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc » ('j') | chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profile_resetter/automatic_profile_resetter_mementos.cc

diff --git a/chrome/browser/profile_resetter/automatic_profile_resetter_mementos.cc b/chrome/browser/profile_resetter/automatic_profile_resetter_mementos.cc

index 84524b9c0793e777c2ca6f9a8ce2d72a4a0402bc..b5075476f12e09d18ccbcf46e1db5fd989e4dfa0 100644

--- a/chrome/browser/profile_resetter/automatic_profile_resetter_mementos.cc

+++ b/chrome/browser/profile_resetter/automatic_profile_resetter_mementos.cc

@@ -55,9 +55,8 @@ std::string LocalStateHostedPromptMemento::ReadValue() const {

return "";

vasilii 2013/10/17 10:57:57 return std::string();

engedy 2013/10/17 15:13:47 Done.

}

std::string value;

- return prompt_shown_dict->GetStringWithoutPathExpansion(profile_key, &value)

- ? value

- : "";

+ return prompt_shown_dict->GetStringWithoutPathExpansion(profile_key, &value) ?

+ value : "";

Peter Kasting 2013/10/16 22:36:51 Nit: "" -> std::string()

engedy 2013/10/17 15:13:47 Done.

}

void LocalStateHostedPromptMemento::StoreValue(const std::string& value) {