Added collecting of data to be fed to the JTL interpreter.

chrome/browser/profile_resetter/automatic_profile_resetter.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_H_
 #define CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string_piece.h"
 #include "base/values.h"
 #include "chrome/browser/profile_resetter/automatic_profile_resetter_mementos.h"
 #include "components/browser_context_keyed_service/browser_context_keyed_service.h"
 
+class AutomaticProfileResetterDelegate;
 class Profile;
 
-// Defines the interface for the delegate that will actually show the prompt
-// and/or report statistics on behalf of the AutomaticProfileResetter.
-// The primary reason for this separation is to facilitate unit testing.
-class AutomaticProfileResetterDelegate {
- public:
-  virtual ~AutomaticProfileResetterDelegate() {}
-
-  // Triggers showing the one-time profile settings reset prompt.
-  virtual void ShowPrompt() = 0;
-
-  // Reports the given metrics through UMA.
-  virtual void ReportStatistics(uint32 satisfied_criteria_mask,
-                                uint32 combined_status_mask) = 0;
-};
-
 // This service becomes busy shortly after start-up, and is responsible for
 // evaluating if the criteria for showing the one-time profile reset prompt
 // are satisfied, and will potentially trigger the prompt, but only a single
 // time during the lifetime of a profile on disk (this is achieved by storing
 // "mementos"). All methods in this class shall be called on the UI thread.
 class AutomaticProfileResetter : public BrowserContextKeyedService {
  public:
+  // Number of bits, and maximum value (exclusive) for the mask whose bits
+  // indicate which of reset criteria were satisfied.
+  static const size_t kSatisfiedCriteriaMaskBits;
+  static const uint32 kSatisfiedCriteriaMaskMaximumValue;
+
+  // Number of bits, and maximum value (exclusive) for the mask whose bits
+  // indicate if any of reset criteria were satisfied, and which of the mementos
+  // were already present.
+  static const size_t kCombinedStatusMaskBits;
+  static const uint32 kCombinedStatusMaskMaximumValue;
+
   explicit AutomaticProfileResetter(Profile* profile);
   virtual ~AutomaticProfileResetter();
 
-  // Initializes the service, and sets up the asynchronous evaluation flow.
-  // Called by AutomaticProfileResetterFactory.
-  void Initialize();
+  // Fires up the service by unleashing the asynchronous evaluation flow, unless
+  // the service has been already disabled in MaybeInitialize() or there is no
+  // |program_| to run (in which case the service also gets disabled).
+  // Called by the AutomaticProfileResetterFactory.
+  void MaybeActivate();

[battre, 2013/10/11 15:05:33]

nit: I think I would prefer to drop the Maybe here and in MaybeInitialize.

[engedy, 2013/10/11 16:42:16]

Done.

 
-  // Should be called after Initialize().
+  // Should be called before MaybeActivate().
   void SetHashSeedForTesting(const base::StringPiece& hash_seed);
 
-  // Should be called after Initialize().
+  // Should be called before MaybeActivate().
   void SetProgramForTesting(const base::StringPiece& program);
 
-  // Should be called after Initialize(). Takes ownership.
+  // Should be called before MaybeActivate(). Takes ownership.
   void SetDelegateForTesting(AutomaticProfileResetterDelegate* delegate);
 
  private:
   struct EvaluationResults;
 
   enum State {
     STATE_UNINITIALIZED,
+    STATE_INITIALIZED,
     STATE_DISABLED,
+    STATE_WAITING_ON_SERVICES,
     STATE_READY,
     STATE_WORKING,
     STATE_DONE
   };
 
+  // Initializes the service if it is enabled in the field trial. Otherwise,
+  // permanently disables the service and also skips the initialization steps.
+  void MaybeInitialize();
+
   // Returns whether or not a dry-run shall be performed.
   bool ShouldPerformDryRun() const;
 
   // Returns whether or not a live-run shall be performed.
   bool ShouldPerformLiveRun() const;
 
+  // Called back by |resetter_delegate_| when the template URL service is ready.
+  // Unleashes the asynchronous evaluation flow.
+  void OnTemplateURLServiceBecameReady();
+
   // Begins the asynchronous evaluation flow, which will assess whether the
   // criteria for showing the reset prompt are met, whether we have already
   // shown the prompt, and, in the end, will potentially trigger the prompt.
   void BeginEvaluationFlow();
 
   // Called back by |memento_in_file_| once it has finished reading the value of
   // the file-based memento. Continues the evaluation flow with collecting state
   // information and assembling it as the input for the evaluator program.
   void ContinueWithEvaluationFlow(const std::string& memento_value_in_file);
 
@@ skipping 33 matching lines @@
   FileHostedPromptMemento memento_in_file_;
 
   scoped_ptr<AutomaticProfileResetterDelegate> delegate_;
 
   base::WeakPtrFactory<AutomaticProfileResetter> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutomaticProfileResetter);
 };
 
 #endif  // CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_H_