Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 270283002: Reland "Prevent liveedit on or under generators with open activations" (Closed)

Created:
6 years, 7 months ago by wingo
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev, rossberg
Visibility:
Public.

Description

Reland "Prevent liveedit on or under generators with open activations" The change relative to the previous CL is a logic change in DropActivationsInActiveThreadImpl. The previous CL skipped the matcher unless the frame was a JS frame; this was correct for MultipleFunctionTarget but not for SingleFrameTarget. I have not been able to reproduce the original failures on either architecture (ia32 or x64; stack frame dropping is unsupported on other architectures). R=yangguo@chromium.org LOG=N TEST=mjsunit/harmony/generators-debug-liveedit.js BUG= Committed: https://code.google.com/p/v8/source/detail?r=21419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -21 lines) Patch
M src/liveedit.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/liveedit.cc View 6 chunks +77 lines, -19 lines 0 comments Download
M src/liveedit-debugger.js View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/generators-debug-liveedit.js View 1 chunk +119 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
6 years, 7 months ago (2014-05-07 09:36:29 UTC) #1
wingo
I would appreciate help in reproducing the original failure; otherwise we can just throw it ...
6 years, 7 months ago (2014-05-07 09:55:08 UTC) #2
Yang
On 2014/05/07 09:55:08, wingo wrote: > I would appreciate help in reproducing the original failure; ...
6 years, 7 months ago (2014-05-20 14:55:59 UTC) #3
Yang
6 years, 7 months ago (2014-05-22 07:33:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21419 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698