Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2702753003: Relanding: avoiding creating strings for canonicalization (Closed)

Created:
3 years, 10 months ago by Dmitry Olshansky
Modified:
3 years, 10 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Relanding: avoiding creating strings for canonicalization Do a hash table for tripples: (list of bytes, start, end) --> canonicalized string R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/aa1e6d4ccf3c43f23d7e2e5bd0fed030f1fa4d38

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/canonicalizer/string_canonicalizer/, style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -17 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/lib/src/fasta/scanner/string_canonicalizer.dart View 1 1 chunk +118 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 5 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Dmitry Olshansky
3 years, 10 months ago (2017-02-17 17:20:57 UTC) #2
ahe
lgtm https://codereview.chromium.org/2702753003/diff/1/pkg/front_end/lib/src/fasta/scanner/canonicalizer.dart File pkg/front_end/lib/src/fasta/scanner/canonicalizer.dart (right): https://codereview.chromium.org/2702753003/diff/1/pkg/front_end/lib/src/fasta/scanner/canonicalizer.dart#newcode1 pkg/front_end/lib/src/fasta/scanner/canonicalizer.dart:1: // Copyright (c) 2017, the Dart project authors. ...
3 years, 10 months ago (2017-02-20 09:18:30 UTC) #3
Dmitry Olshansky
3 years, 10 months ago (2017-02-20 14:19:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
aa1e6d4ccf3c43f23d7e2e5bd0fed030f1fa4d38 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698