Issue 270273005: Harden yet more runtime functions

Issue 270273005: Harden yet more runtime functions (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow

Modified:
6 years, 7 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Harden yet more runtime functions R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21197

Patch Set 2 : fixed nits #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -28 lines)			Patch
M	src/debug.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/debug.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/liveedit.h	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1	22 chunks	+44 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

lgtm (minor nits) https://codereview.chromium.org/270273005/diff/1/src/liveedit.h File src/liveedit.h (right): https://codereview.chromium.org/270273005/diff/1/src/liveedit.h#newcode282 src/liveedit.h:282: Isolate* iso = array->GetIsolate(); nit: iso ...

6 years, 7 months ago (2014-05-07 14:47:18 UTC) #2

Jakob Kummerow

https://codereview.chromium.org/270273005/diff/1/src/liveedit.h File src/liveedit.h (right): https://codereview.chromium.org/270273005/diff/1/src/liveedit.h#newcode282 src/liveedit.h:282: Isolate* iso = array->GetIsolate(); On 2014/05/07 14:47:18, Dmitry Lomov ...

6 years, 7 months ago (2014-05-08 09:32:56 UTC) #3

Jakob Kummerow

6 years, 7 months ago (2014-05-08 09:33:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21197 (tree was closed).

Expand Messages | Collapse Messages