Extract kArcEnabled preference from ArcSessionManager part 1.

chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h"
 
 #include <algorithm>
 #include <numeric>
 #include <string>
 
 #include "base/files/file_util.h"
 #include "base/sys_info.h"
 #include "base/task_scheduler/post_task.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browsing_data/browsing_data_appcache_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_cache_storage_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_channel_id_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_cookie_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_database_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_file_system_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_flash_lso_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_indexed_db_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_local_storage_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_service_worker_helper.h"
-#include "chrome/browser/chromeos/arc/arc_session_manager.h"
 #include "chrome/browser/chromeos/arc/arc_util.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/file_manager/path_util.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/cryptohome/homedir_methods.h"
 #include "components/arc/arc_util.h"
 #include "components/browsing_data/content/conditional_cache_counting_helper.h"
 #include "components/drive/chromeos/file_system_interface.h"
@@ skipping 372 matching lines @@
         base::StringValue(size_string));
   }
 }
 
 void StorageManagerHandler::UpdateArcSize() {
   if (updating_arc_size_)
     return;
   updating_arc_size_ = true;
 
   Profile* const profile = Profile::FromWebUI(web_ui());
-  if (!arc::IsArcAllowedForProfile(profile) ||
-      arc::IsArcOptInVerificationDisabled() ||
-      !arc::ArcSessionManager::Get()->IsArcPlayStoreEnabled()) {
+  if (!arc::IsArcPlayStoreEnabledForProfile(profile) ||

[hidehiko, 2017/02/17 15:07:19]

Note: IsArcAllowedForProfile is no longer needed here, because
IsArcPlayStoreEnabledForProfile() contains it.

+      arc::IsArcOptInVerificationDisabled()) {

[Yusuke Sato, 2017/02/17 22:27:09]

Mostly OT: do you know why this check is necessary? code comment?

[hidehiko, 2017/02/20 18:18:44]

I'm guessing we'd like to show the section only when ARC is running.
Let me confirm with the original author. At the moment, as this is off-topic,
let me work on it in a following CL soon.

     return;
   }
 
   // Shows the item "Android apps and cache" and start calculating size.
   web_ui()->CallJavascriptFunctionUnsafe(
       "options.StorageManager.showArcItem");
   bool success = arc::ArcStorageManager::Get()->GetApplicationsSize(
       base::Bind(&StorageManagerHandler::OnGetArcSize,
                  weak_ptr_factory_.GetWeakPtr()));
   if (!success)
@@ skipping 16 matching lines @@
   web_ui()->CallJavascriptFunctionUnsafe("options.StorageManager.setArcSize",
                                          base::StringValue(size_string));
 }
 
 void StorageManagerHandler::OnClearDriveCacheDone(bool success) {
   UpdateDriveCacheSize();
 }
 
 }  // namespace options
 }  // namespace chromeos