Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: ios/chrome/browser/ui/stack_view/stack_view_egtest.mm

Issue 2702713002: Mark StackViewTestCase.testCloseAllTabs as flaky on simulator (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/stack_view/stack_view_egtest.mm
diff --git a/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm b/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm
index ab24504ecf4702b6be59bdc905f215a7889503d0..6d2f88fcccce4ea72a79d2f603bd590b1b6bd6a0 100644
--- a/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm
+++ b/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm
@@ -187,7 +187,13 @@ void SelectTabUsingStackView(Tab* tab) {
}
// Tests closing all Tabs in the stack view.
-- (void)testCloseAllTabs {
+// TODO(crbug.com/693517): Re-enable this test on simulator.
+#if TARGET_IPHONE_SIMULATOR
+#define MAYBE_testCloseAllTabs FLAKY_testCloseAllTabs
+#else
+#define MAYBE_testCloseAllTabs testCloseAllTabs
+#endif
+- (void)MAYBE_testCloseAllTabs {
// The StackViewController is only used on iPhones.
if (IsIPadIdiom())
EARL_GREY_TEST_SKIPPED(@"Stack view is not used on iPads.");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698