Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2702693002: Add/update some comments in components/image_fetcher (Closed)

Created:
3 years, 10 months ago by Marc Treib
Modified:
3 years, 10 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add/update some comments in components/image_fetcher BUG=none Review-Url: https://codereview.chromium.org/2702693002 Cr-Commit-Position: refs/heads/master@{#451641} Committed: https://chromium.googlesource.com/chromium/src/+/4317ace9456f17a6fd22049f008d35ac4c32e469

Patch Set 1 #

Total comments: 7

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/search/suggestions/image_decoder_impl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/image_fetcher/image_fetcher.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/image_fetcher/image_fetcher_impl.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Marc Treib
PTAL at this comments-only CL :) https://codereview.chromium.org/2702693002/diff/1/components/image_fetcher/image_fetcher.h File components/image_fetcher/image_fetcher.h (right): https://codereview.chromium.org/2702693002/diff/1/components/image_fetcher/image_fetcher.h#newcode45 components/image_fetcher/image_fetcher.h:45: // crbug.com/689020), add ...
3 years, 10 months ago (2017-02-17 09:44:32 UTC) #2
Marc Treib
On 2017/02/17 09:44:32, Marc Treib wrote: > PTAL at this comments-only CL :) > > ...
3 years, 10 months ago (2017-02-20 11:01:49 UTC) #3
markusheintz_
https://codereview.chromium.org/2702693002/diff/1/chrome/browser/search/suggestions/image_decoder_impl.h File chrome/browser/search/suggestions/image_decoder_impl.h (right): https://codereview.chromium.org/2702693002/diff/1/chrome/browser/search/suggestions/image_decoder_impl.h#newcode18 chrome/browser/search/suggestions/image_decoder_impl.h:18: // nothing to do with suggestions. This is the ...
3 years, 10 months ago (2017-02-20 13:14:44 UTC) #4
Marc Treib
Thanks! PTAL again https://codereview.chromium.org/2702693002/diff/1/chrome/browser/search/suggestions/image_decoder_impl.h File chrome/browser/search/suggestions/image_decoder_impl.h (right): https://codereview.chromium.org/2702693002/diff/1/chrome/browser/search/suggestions/image_decoder_impl.h#newcode18 chrome/browser/search/suggestions/image_decoder_impl.h:18: // nothing to do with suggestions. ...
3 years, 10 months ago (2017-02-20 14:23:36 UTC) #5
markusheintz_
On 2017/02/20 14:23:36, Marc Treib wrote: > Thanks! PTAL again > > https://codereview.chromium.org/2702693002/diff/1/chrome/browser/search/suggestions/image_decoder_impl.h > File ...
3 years, 10 months ago (2017-02-20 15:15:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702693002/20001
3 years, 10 months ago (2017-02-20 15:16:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/325407)
3 years, 10 months ago (2017-02-20 16:13:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702693002/20001
3 years, 10 months ago (2017-02-20 16:33:13 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 17:10:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4317ace9456f17a6fd22049f008d...

Powered by Google App Engine
This is Rietveld 408576698