Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: third_party/WebKit/Source/modules/webauth/WebAuthentication.idl

Issue 2702653002: Patch #1 of multiple. Add webauth .mojom and initial usage of makeCredential. (Closed)
Patch Set: Adding additional comments to mojom structs. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webauth/WebAuthentication.idl
diff --git a/third_party/WebKit/Source/modules/webauth/WebAuthentication.idl b/third_party/WebKit/Source/modules/webauth/WebAuthentication.idl
index fb2b4899951fcda2eed9c4f58e3c6195bec9fc96..c2fe634740621cffbd873f904fe842382095aadb 100644
--- a/third_party/WebKit/Source/modules/webauth/WebAuthentication.idl
+++ b/third_party/WebKit/Source/modules/webauth/WebAuthentication.idl
@@ -8,6 +8,6 @@
RuntimeEnabled=WebAuth,
SecureContext
] interface WebAuthentication {
- [CallWith=ScriptState] Promise<sequence<ScopedCredentialInfo>> makeCredential(RelyingPartyAccount accountInformation, sequence<ScopedCredentialParameters> cryptoParameters, BufferSource attestationChallenge, optional ScopedCredentialOptions options);
- [CallWith=ScriptState] Promise<sequence<WebAuthnAssertion>> getAssertion(BufferSource assertionChallenge, optional AuthenticationAssertionOptions options);
+ [CallWith=ScriptState] Promise<sequence<ScopedCredentialInfo>> MakeCredential(RelyingPartyAccount accountInformation, sequence<ScopedCredentialParameters> cryptoParameters, BufferSource attestationChallenge, optional ScopedCredentialOptions options);
dcheng 2017/05/04 07:22:35 WebIDL methods should be named makeCredential() an
kpaulhamus 2017/05/05 01:32:36 Ah, okay, I'm finally getting it. Yeah, the rename
+ [CallWith=ScriptState] Promise<sequence<WebAuthnAssertion>> GetAssertion(BufferSource assertionChallenge, optional AuthenticationAssertionOptions options);
};

Powered by Google App Engine
This is Rietveld 408576698