Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: third_party/WebKit/Source/modules/webauth/WebAuthentication.h

Issue 2702653002: Patch #1 of multiple. Add webauth .mojom and initial usage of makeCredential. (Closed)
Patch Set: Addressing comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webauth/WebAuthentication.h
diff --git a/third_party/WebKit/Source/modules/webauth/WebAuthentication.h b/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
index ba0134f14636caaa121b4b5e22fd3fd30ee11555..4c37cac9a51896251ce56377183d62f10767d819 100644
--- a/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
+++ b/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
@@ -8,27 +8,28 @@
#include "bindings/core/v8/ArrayBufferOrArrayBufferView.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptWrappable.h"
+#include "components/webauth/authenticator.mojom-blink.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/dom/DOMArrayBuffer.h"
#include "modules/webauth/AuthenticationAssertionOptions.h"
-#include "modules/webauth/RelyingPartyAccount.h"
-#include "modules/webauth/ScopedCredentialOptions.h"
-#include "modules/webauth/ScopedCredentialParameters.h"
+#include "modules/webauth/ScopedCredentialInfo.h"
namespace blink {
-class LocalFrame;
-class ScriptState;
class RelyingPartyAccount;
class AuthenticationAssertionOptions;
-class ScopedCredentialParameters;
class ScopedCredentialOptions;
+class ScopedCredentialParameters;
+class ScriptPromiseResolver;
typedef ArrayBufferOrArrayBufferView BufferSource;
class WebAuthentication final
: public GarbageCollectedFinalized<WebAuthentication>,
- public ScriptWrappable {
+ public ScriptWrappable,
+ public ContextLifecycleObserver {
DEFINE_WRAPPERTYPEINFO();
+ USING_GARBAGE_COLLECTED_MIXIN(WebAuthentication);
public:
static WebAuthentication* Create(LocalFrame& frame) {
@@ -39,6 +40,7 @@ class WebAuthentication final
void Dispose();
+ // WebAuthentication.idl
ScriptPromise makeCredential(ScriptState*,
const RelyingPartyAccount&,
const HeapVector<ScopedCredentialParameters>,
@@ -48,12 +50,27 @@ class WebAuthentication final
const BufferSource&,
const AuthenticationAssertionOptions&);
- DEFINE_INLINE_TRACE() {}
+ // ContextLifecycleObserver overrides.
+ void ContextDestroyed(ExecutionContext*) override;
+
+ webauth::mojom::blink::Authenticator* authenticator() const {
+ return m_authenticator.get();
+ }
+
+ void onMakeCredential(ScriptPromiseResolver*,
+ Vector<webauth::mojom::blink::ScopedCredentialInfoPtr>);
+ bool markRequestComplete(ScriptPromiseResolver*);
+
+ void onAuthenticatorConnectionError();
+
+ DECLARE_VIRTUAL_TRACE();
private:
explicit WebAuthentication(LocalFrame&);
-};
+ webauth::mojom::blink::AuthenticatorPtr m_authenticator;
+ HeapHashSet<Member<ScriptPromiseResolver>> m_authenticatorRequests;
+};
} // namespace blink
#endif // WebAuthentication_h

Powered by Google App Engine
This is Rietveld 408576698