Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: components/webauth/authenticator.mojom

Issue 2702653002: Patch #1 of multiple. Add webauth .mojom and initial usage of makeCredential. (Closed)
Patch Set: Updated based on SharedArrayBuffer changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 [JavaPackage="org.chromium.webauth.mojom"]
6 module webauth.mojom;
7
8 struct ScopedCredentialInfo {
dcheng 2017/04/20 13:04:44 Nit: please add some more comments to these struct
kpaulhamus 2017/04/22 01:04:44 Comments added. Yeah, the byte arrays are all blob
dcheng 2017/04/24 12:25:26 Is there any limit on the size of fields here? Any
9 array<uint8> client_data;
10 array<uint8> attestation;
11 };
12
13 struct RelyingPartyAccount {
14 string rp_display_name;
dcheng 2017/04/20 13:04:43 It's not clear what the difference between rp_disp
kpaulhamus 2017/04/22 01:04:44 I've added comments for RelyingPartyAccount in one
15 string display_name;
16 string id;
17 string name;
18 string image_url;
dcheng 2017/04/20 13:04:43 Nit: url.mojom.Url
kpaulhamus 2017/04/22 01:04:44 This is coming in a follow-up CL
19 };
20
21 struct ScopedCredentialParameters {
22 ScopedCredentialType type;
23 // TODO(kpaulhamus): add AlgorithmIdentifier algorithm;
24 };
25
26 struct ScopedCredentialOptions {
27 int32 timeout_seconds;
28 string rp_id;
dcheng 2017/04/20 13:04:43 Ditto: it's not clear what rp_ stands for here
kpaulhamus 2017/04/22 01:04:44 Ok, I'll unabbreviate same as above.
29 array<ScopedCredentialDescriptor> exclude_list;
30 // TODO(kpaulhamus): add Extensions
31 };
32
33 enum ScopedCredentialType {
34 SCOPEDCRED,
35 };
36
37 struct ScopedCredentialDescriptor {
38 ScopedCredentialType type;
39 array<uint8> id;
40 array<Transport> transports;
41 };
42
43 enum Transport {
44 USB,
45 NFC,
46 BLE,
47 };
48
49 interface Authenticator {
50 makeCredential(RelyingPartyAccount account_information,
51 array<ScopedCredentialParameters> crypto_parameters,
52 array<uint8> attestation_challenge,
53 ScopedCredentialOptions? options)
54 => (array<ScopedCredentialInfo> scoped_credentials);
55 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698