Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: net/cert/ct_log_verifier_unittest.cc

Issue 27026002: CT: Adding preliminary Certificate Transparency support to Chromium. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Distinguish between SCTs from unknown logs and unverified ones Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/ct_log_verifier.cc ('k') | net/cert/ct_objects_extractor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_log_verifier_unittest.cc
diff --git a/net/cert/ct_log_verifier_unittest.cc b/net/cert/ct_log_verifier_unittest.cc
index 4412258875615d9b1e6bf24661051fc40437da84..ad6f4f0d04b1b32ff3cffef5d1692b670539f50c 100644
--- a/net/cert/ct_log_verifier_unittest.cc
+++ b/net/cert/ct_log_verifier_unittest.cc
@@ -35,7 +35,9 @@ TEST_F(CTLogVerifierTest, VerifiesCertSCT) {
ct::SignedCertificateTimestamp cert_sct;
ct::GetX509CertSCT(&cert_sct);
- EXPECT_TRUE(log_->Verify(cert_entry, cert_sct));
+ ASSERT_EQ(
+ CTLogVerifier::SCT_VERIFIED_OK,
+ log_->Verify(cert_entry, cert_sct));
}
TEST_F(CTLogVerifierTest, VerifiesPrecertSCT) {
@@ -45,7 +47,9 @@ TEST_F(CTLogVerifierTest, VerifiesPrecertSCT) {
ct::SignedCertificateTimestamp precert_sct;
ct::GetPrecertSCT(&precert_sct);
- EXPECT_TRUE(log_->Verify(precert_entry, precert_sct));
+ ASSERT_EQ(
+ CTLogVerifier::SCT_VERIFIED_OK,
+ log_->Verify(precert_entry, precert_sct));
}
TEST_F(CTLogVerifierTest, FailsInvalidTimestamp) {
@@ -58,7 +62,9 @@ TEST_F(CTLogVerifierTest, FailsInvalidTimestamp) {
// Mangle the timestamp, so that it should fail signature validation.
cert_sct.timestamp = base::Time::Now();
- EXPECT_FALSE(log_->Verify(cert_entry, cert_sct));
+ ASSERT_EQ(
+ CTLogVerifier::SCT_VERIFICATION_FAILED,
+ log_->Verify(cert_entry, cert_sct));
}
TEST_F(CTLogVerifierTest, FailsInvalidLogID) {
@@ -72,7 +78,8 @@ TEST_F(CTLogVerifierTest, FailsInvalidLogID) {
// attempting signature validation.
cert_sct.log_id.assign(cert_sct.log_id.size(), '\0');
- EXPECT_FALSE(log_->Verify(cert_entry, cert_sct));
+ ASSERT_EQ(
+ CTLogVerifier::SCT_NOT_FROM_THIS_LOG, log_->Verify(cert_entry, cert_sct));
}
} // namespace net
« no previous file with comments | « net/cert/ct_log_verifier.cc ('k') | net/cert/ct_objects_extractor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698