Remove the extra separator appears beside overview tray

ash/common/system/overview/overview_button_tray.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/overview/overview_button_tray.h"
 
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/session/session_state_delegate.h"
 #include "ash/common/shelf/shelf_constants.h"
 #include "ash/common/shelf/wm_shelf_util.h"
@@ skipping 38 matching lines @@
   } else {
     SetContentsBackground(true);
     gfx::ImageSkia* image_non_md =
         ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
             IDR_AURA_UBER_TRAY_OVERVIEW_MODE);
     icon_->SetImage(image_non_md);
   }
   SetIconBorderForShelfAlignment();
   tray_container()->AddChildView(icon_);
 
+  // Since |overview_button_tray| locates on the right most position, no
+  // separator is required on its right side.

[tdanderson, 2017/02/16 20:25:03]

How about something like "Since OverviewButtonTray is located on the rightmost
position of a horizontal shelf, no separator is required." to make it more
general? Note that using the class name 'OverviewButtonTray' is preferred over
'|overview_button_tray|' since the |...| notation should only be used for
identifier names or |this|.

Also, in the SystemTray constructor above the set_separator_visibility() call
you say "Since |system_tray| locates on the right most position..." but this
isn't true if overview mode is enabled. The reason we don't need a separator for
the system tray is because the user avatar is on the right hand side and that is
sufficient to indicate separation. Can you also please change that documentation
accordingly?

[yiyix, 2017/02/16 20:43:43]

I have update all comments. Could you check it again? Thank you

+  set_separator_visibility(false);
+
   WmShell::Get()->AddShellObserver(this);
   WmShell::Get()->GetSessionStateDelegate()->AddSessionStateObserver(this);
 }
 
 OverviewButtonTray::~OverviewButtonTray() {
   WmShell::Get()->RemoveShellObserver(this);
   WmShell::Get()->GetSessionStateDelegate()->RemoveSessionStateObserver(this);
 }
 
 void OverviewButtonTray::UpdateAfterLoginStatusChange(LoginStatus status) {
@@ skipping 82 matching lines @@
       !session_state_delegate->IsScreenLocked() &&
       session_state_delegate->GetSessionState() ==
           session_manager::SessionState::ACTIVE &&
       shell->system_tray_delegate()->GetUserLoginStatus() !=
           LoginStatus::KIOSK_APP &&
       shell->system_tray_delegate()->GetUserLoginStatus() !=
           LoginStatus::ARC_KIOSK_APP);
 }
 
 }  // namespace ash