Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 270253004: Enable oilpan in modules/mediasource (Closed)

Created:
6 years, 7 months ago by keishi
Modified:
6 years, 5 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Visibility:
Public.

Description

Enable oilpan in modules/mediasource Replacing transition types to real types. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173593 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177275

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -40 lines) Patch
M Source/modules/mediasource/HTMLVideoElementMediaSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/HTMLVideoElementMediaSource.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.h View 1 2 3 4 3 chunks +5 lines, -6 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 2 3 4 5 3 chunks +7 lines, -6 lines 0 comments Download
M Source/modules/mediasource/MediaSourceRegistry.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceRegistry.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/mediasource/SourceBufferList.h View 1 2 3 4 3 chunks +6 lines, -7 lines 1 comment Download
M Source/modules/mediasource/SourceBufferList.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBufferList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/VideoPlaybackQuality.h View 1 2 3 4 5 1 chunk +2 lines, -4 lines 0 comments Download
M Source/modules/mediasource/VideoPlaybackQuality.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/VideoPlaybackQuality.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
keishi
6 years, 7 months ago (2014-05-07 11:06:09 UTC) #1
zerny-chromium
lgtm
6 years, 7 months ago (2014-05-07 11:12:31 UTC) #2
haraken
Assuming that you removed all RefPtrs to the MediaSourceBase hierarchy, LGTM. (Compilers won't complain about ...
6 years, 7 months ago (2014-05-07 11:31:22 UTC) #3
keishi
Checked for RefPtrs. https://codereview.chromium.org/270253004/diff/1/Source/modules/mediasource/VideoPlaybackQuality.h File Source/modules/mediasource/VideoPlaybackQuality.h (right): https://codereview.chromium.org/270253004/diff/1/Source/modules/mediasource/VideoPlaybackQuality.h#newcode36 Source/modules/mediasource/VideoPlaybackQuality.h:36: #include "wtf/RefCounted.h" On 2014/05/07 11:31:22, haraken ...
6 years, 7 months ago (2014-05-07 12:26:45 UTC) #4
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 7 months ago (2014-05-08 01:52:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/270253004/20001
6 years, 7 months ago (2014-05-08 01:54:06 UTC) #6
commit-bot: I haz the power
Change committed as 173593
6 years, 7 months ago (2014-05-08 03:05:57 UTC) #7
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 6 months ago (2014-06-26 06:45:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/270253004/80001
6 years, 6 months ago (2014-06-26 06:45:59 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-26 07:57:42 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 09:05:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/13662)
6 years, 6 months ago (2014-06-26 09:05:55 UTC) #12
tkent
https://codereview.chromium.org/270253004/diff/80001/Source/modules/mediasource/MediaSource.cpp File Source/modules/mediasource/MediaSource.cpp (right): https://codereview.chromium.org/270253004/diff/80001/Source/modules/mediasource/MediaSource.cpp#newcode262 Source/modules/mediasource/MediaSource.cpp:262: visitor->trace(m_asyncEventQueue); This is causing crashes in Debug build. We ...
6 years, 5 months ago (2014-06-29 23:30:43 UTC) #13
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 5 months ago (2014-07-01 07:13:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/270253004/100001
6 years, 5 months ago (2014-07-01 07:14:21 UTC) #15
commit-bot: I haz the power
Change committed as 177275
6 years, 5 months ago (2014-07-01 07:58:58 UTC) #16
Erik Corry
https://codereview.chromium.org/270253004/diff/100001/Source/modules/mediasource/SourceBufferList.h File Source/modules/mediasource/SourceBufferList.h (right): https://codereview.chromium.org/270253004/diff/100001/Source/modules/mediasource/SourceBufferList.h#newcode50 Source/modules/mediasource/SourceBufferList.h:50: return adoptRefCountedGarbageCollected(new SourceBufferList(context, asyncEventQueue)); This does not compile for ...
6 years, 5 months ago (2014-07-01 08:53:56 UTC) #17
Erik Corry
On 2014/07/01 08:53:56, Erik Corry wrote: > https://codereview.chromium.org/270253004/diff/100001/Source/modules/mediasource/SourceBufferList.h > File Source/modules/mediasource/SourceBufferList.h (right): > > https://codereview.chromium.org/270253004/diff/100001/Source/modules/mediasource/SourceBufferList.h#newcode50 ...
6 years, 5 months ago (2014-07-01 08:54:24 UTC) #18
keishi
6 years, 5 months ago (2014-07-01 08:57:30 UTC) #19
Message was sent while issue was closed. 
On 2014/07/01 08:54:24, Erik Corry wrote:
> On 2014/07/01 08:53:56, Erik Corry wrote:
> >
>
https://codereview.chromium.org/270253004/diff/100001/Source/modules/mediasou...
> > File Source/modules/mediasource/SourceBufferList.h (right):
> > 
> >
>
https://codereview.chromium.org/270253004/diff/100001/Source/modules/mediasou...
> > Source/modules/mediasource/SourceBufferList.h:50: return
> > adoptRefCountedGarbageCollected(new SourceBufferList(context,
> asyncEventQueue));
> > This does not compile for me in the oilpan=1 config. Ian says it should be
> > adoptRefCountedGarbageCollectedWillBeGarbageCollected
> 
> Or perhaps adoptRefCountedGarbageCollectedWillBeNoop

Sorry. I will fix this.

Powered by Google App Engine
This is Rietveld 408576698