Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Issue 2702523005: MD Settings: long dialog body should have overscroll line. (Closed)
Patch Set: format and annotation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
diff --git a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
index 2747f0e648fdf5e0b014fc00deb63a31e3300da5..9413ac9903f05169a79748ebe3ccb161eda80479 100644
--- a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
+++ b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
@@ -61,6 +61,14 @@
flex-direction: column;
/* TODO(dbeam): copy <paper-dialog-scrollable>'s dividers? */
dpapad 2017/03/29 17:42:16 This TODO is being addressed with this CL. Can we
scottchen 2017/03/29 21:02:08 Done.
overflow: auto;
+ /* Prevent layout moving when border does appear. */
+ border-bottom: 1px solid transparent;
+
+ @apply(--cr-dialog-body-container);
+ }
+
+ .body-container.bottom-scrollable {
+ border-bottom: 1px solid var(--paper-grey-300);
}
:host ::content .body {
@@ -110,6 +118,7 @@
</div>
<div class="body-container">
<content select=".body"></content>
+ <span id="bodyBottomMarker">
</div>
<content select=".button-container"></content>
<content select=".footer"></content>

Powered by Google App Engine
This is Rietveld 408576698