Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Issue 2702523005: MD Settings: long dialog body should have overscroll line. (Closed)
Patch Set: remove unused variable Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
diff --git a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
index 2747f0e648fdf5e0b014fc00deb63a31e3300da5..14a5a866e2d4e464289772fb38d5256ff0eed063 100644
--- a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
+++ b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
@@ -59,8 +59,17 @@
.body-container {
display: flex;
flex-direction: column;
- /* TODO(dbeam): copy <paper-dialog-scrollable>'s dividers? */
overflow: auto;
+ @apply(--cr-dialog-body-container);
+ }
+
+ :host([show-scroll-borders]) .body-container {
+ /* Prevent layout moving when border does appear. */
+ border-bottom: 1px solid transparent;
+ }
+
+ :host([show-scroll-borders]) .body-container.bottom-scrollable {
+ border-bottom: 1px solid var(--paper-grey-300);
}
:host ::content .body {
@@ -110,6 +119,7 @@
</div>
<div class="body-container">
<content select=".body"></content>
+ <span id="bodyBottomMarker"></span>
</div>
<content select=".button-container"></content>
<content select=".footer"></content>
« no previous file with comments | « chrome/test/data/webui/cr_elements/cr_dialog_test.js ('k') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698