MD Settings: long dialog body should have overscroll line.

ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Index: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
diff --git a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
index 2747f0e648fdf5e0b014fc00deb63a31e3300da5..a703635b90a17cdfd20eb6afb0d831c246d27d53 100644
--- a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
+++ b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
@@ -59,8 +59,15 @@
       .body-container {
         display: flex;
         flex-direction: column;
-        /* TODO(dbeam): copy <paper-dialog-scrollable>'s dividers? */
         overflow: auto;
+        /* Prevent layout moving when border does appear. */
+        border-bottom: 1px solid transparent;
+
+        @apply(--cr-dialog-body-container);
+      }

[dpapad, 2017/03/29 21:12:22]

How about moving those border showing related rules to a different rule as
follows? This makes it more explicit that they are applicable only when
show-scroll-borders is applied.

:host[show-scroll-borders] .body-container {...}
:host[show-scroll-borders] .body-container.bottom-scrollable {...}

For this to work showScrollBorders needs "reflectToAttribute: true".

[scottchen, 2017/03/30 06:42:47]

Done.

[dpapad, 2017/03/30 17:18:39]

Did you forget to upload latest patch? I don't see it.

[scottchen, 2017/03/30 18:11:18]

..I keep forgetting that it would prompt me for a message after "git cl upload",
my bad.

+
+      .body-container.bottom-scrollable {
+        border-bottom: 1px solid var(--paper-grey-300);
       }
 
       :host ::content .body {
@@ -110,6 +117,7 @@
     </div>
     <div class="body-container">
       <content select=".body"></content>
+      <span id="bodyBottomMarker">

[dpapad, 2017/03/29 21:12:22]

Thi CL only adds a border to the bottom, but in the standup you mentioned that a
border should be shown both on top and bottom, depending on whether there is
more content to scroll. Can you clarify?

[scottchen, 2017/03/30 06:42:47]

I think I misspoke during standup - in the case of dialog, there's always a
border below the header and on top of the body, so top overscroll border is not
necessary.

     </div>
     <content select=".button-container"></content>
     <content select=".footer"></content>