MD Settings: long dialog body should have overscroll line.

ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'cr-dialog' is a component for showing a modal dialog. If the
  * dialog is closed via close(), a 'close' event is fired. If the dialog is
  * canceled via cancel(), a 'cancel' event is fired followed by a 'close' event.
  * Additionally clients can inspect the dialog's |returnValue| property inside
  * the 'close' event listener to determine whether it was canceled or just
@@ skipping 13 matching lines @@
     /**
      * True if the dialog should remain open on 'popstate' events. This is used
      * for navigable dialogs that have their separate navigation handling code.
      */
     ignorePopstate: {
       type: Boolean,
       value: false,
     },
   },
 
+  /** @private {?IntersectionObserver} */
+  intersectionObserver_: null,
+
   /** @override */
   ready: function() {
     // If the active history entry changes (i.e. user clicks back button),
     // all open dialogs should be cancelled.
     window.addEventListener('popstate', function() {
       if (!this.ignorePopstate && this.open)
         this.cancel();
     }.bind(this));
   },
 
+  attached: function() {

[dpapad, 2017/03/29 17:42:16]

@override

[scottchen, 2017/03/29 21:02:08]

Done.

+    var bodyContainer = this.$$('.body-container');
+
+    var callback = function(entries) {
+      assert(entries.length == 1);
+      entries[0].intersectionRatio == 0 ?
+          bodyContainer.classList.add('bottom-scrollable') :
+          bodyContainer.classList.remove('bottom-scrollable');
+    };
+
+    this.intersectionObserver_ = new IntersectionObserver(callback, {
+      root: bodyContainer,
+      threshold: 0,
+    });
+    this.intersectionObserver_.observe(this.$.bodyBottomMarker);

[dpapad, 2017/03/29 17:42:16]

We only have a few dialogs that use this functionality. Can we make it opt-in
instead of adding the handlers for all dialogs, even the ones that don't need
it?

something like

<dialog is="cr-dialog" show-scroll-borders>....</dialog>

[scottchen, 2017/03/29 21:02:08]

Done.

+  },
+
+  detached: function() {

[dpapad, 2017/03/29 17:42:16]

@override

[scottchen, 2017/03/29 21:02:08]

Done.

+    this.intersectionObserver_.disconnect();
+    this.intersectionObserver_ = null;
+  },
+
   cancel: function() {
     this.fire('cancel');
     HTMLDialogElement.prototype.close.call(this, '');
   },
 
   /**
    * @param {string=} opt_returnValue
    * @override
    */
   close: function(opt_returnValue) {
     HTMLDialogElement.prototype.close.call(this, 'success');
   },
 
   /** @return {!PaperIconButtonElement} */
   getCloseButton: function() {
     return this.$.close;
   },
 });