Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Issue 2702523005: MD Settings: long dialog body should have overscroll line. (Closed)
Patch Set: revert format change Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/assert.html"> 2 <link rel="import" href="chrome://resources/html/assert.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/default-th eme.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/default-th eme.html">
6 6
7 <dom-module id="cr-dialog"> 7 <dom-module id="cr-dialog">
8 <template> 8 <template>
9 <style> 9 <style>
10 :host { 10 :host {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 }; 52 };
53 -webkit-margin-end: 6px; 53 -webkit-margin-end: 6px;
54 /* <paper-icon-button> overrides --iron-icon-{height,width}, so this 54 /* <paper-icon-button> overrides --iron-icon-{height,width}, so this
55 * padding essentially reduces 40x40 to 20x20. */ 55 * padding essentially reduces 40x40 to 20x20. */
56 padding: 10px; 56 padding: 10px;
57 } 57 }
58 58
59 .body-container { 59 .body-container {
60 display: flex; 60 display: flex;
61 flex-direction: column; 61 flex-direction: column;
62 /* TODO(dbeam): copy <paper-dialog-scrollable>'s dividers? */
63 overflow: auto; 62 overflow: auto;
63 @apply(--cr-dialog-body-container);
64 }
65
66 :host([show-scroll-borders]) .body-container {
67 /* Prevent layout moving when border does appear. */
68 border-bottom: 1px solid transparent;
69 }
70
71 :host([show-scroll-borders]) .body-container.bottom-scrollable {
72 border-bottom: 1px solid var(--paper-grey-300);
64 } 73 }
65 74
66 :host ::content .body { 75 :host ::content .body {
67 padding-bottom: 12px; 76 padding-bottom: 12px;
68 padding-top: 12px; 77 padding-top: 12px;
69 } 78 }
70 79
71 :host ::content .body, 80 :host ::content .body,
72 :host ::content .title { 81 :host ::content .title {
73 -webkit-padding-end: 24px; 82 -webkit-padding-end: 24px;
(...skipping 29 matching lines...) Expand all
103 <div class="top-container"> 112 <div class="top-container">
104 <div class="title-container" tabindex="-1"> 113 <div class="title-container" tabindex="-1">
105 <content select=".title"></content> 114 <content select=".title"></content>
106 </div> 115 </div>
107 <paper-icon-button icon="cr:clear" on-tap="cancel" id="close" 116 <paper-icon-button icon="cr:clear" on-tap="cancel" id="close"
108 aria-label$="[[closeText]]"> 117 aria-label$="[[closeText]]">
109 </paper-icon-button> 118 </paper-icon-button>
110 </div> 119 </div>
111 <div class="body-container"> 120 <div class="body-container">
112 <content select=".body"></content> 121 <content select=".body"></content>
122 <span id="bodyBottomMarker">
dpapad 2017/03/30 18:25:00 <span> needs a closing tag, no?
scottchen 2017/03/30 19:24:34 Done. Curious if it's possible to add a presubmit
dpapad 2017/03/30 19:41:22 It would require parsing HTML. Probably possible (
113 </div> 123 </div>
114 <content select=".button-container"></content> 124 <content select=".button-container"></content>
115 <content select=".footer"></content> 125 <content select=".footer"></content>
116 </template> 126 </template>
117 <script src="cr_dialog.js"></script> 127 <script src="cr_dialog.js"></script>
118 </dom-module> 128 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698