Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2702523003: [DevTools] Continue GlassPane refactoring. (Closed)
Patch Set: element Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Network.NetworkLogViewColumns = class { 7 Network.NetworkLogViewColumns = class {
8 /** 8 /**
9 * @param {!Network.NetworkLogView} networkLogView 9 * @param {!Network.NetworkLogView} networkLogView
10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator 10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 _manageCustomHeaderDialog() { 437 _manageCustomHeaderDialog() {
438 var customHeaders = []; 438 var customHeaders = [];
439 for (var columnConfig of this._columns) { 439 for (var columnConfig of this._columns) {
440 if (columnConfig.isResponseHeader) 440 if (columnConfig.isResponseHeader)
441 customHeaders.push({title: columnConfig.title, editable: columnConfig.is CustomHeader}); 441 customHeaders.push({title: columnConfig.title, editable: columnConfig.is CustomHeader});
442 } 442 }
443 var manageCustomHeaders = new Network.NetworkManageCustomHeadersView( 443 var manageCustomHeaders = new Network.NetworkManageCustomHeadersView(
444 customHeaders, headerTitle => !!this._addCustomHeader(headerTitle), this ._changeCustomHeader.bind(this), 444 customHeaders, headerTitle => !!this._addCustomHeader(headerTitle), this ._changeCustomHeader.bind(this),
445 this._removeCustomHeader.bind(this)); 445 this._removeCustomHeader.bind(this));
446 var dialog = new UI.Dialog(); 446 var dialog = new UI.Dialog();
447 manageCustomHeaders.show(dialog.element); 447 manageCustomHeaders.show(dialog.contentElement);
448 dialog.setWrapsContent(true); 448 dialog.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent);
449 dialog.show(); 449 dialog.showDialog(this._networkLogView.element);
450 } 450 }
451 451
452 /** 452 /**
453 * @param {string} headerId 453 * @param {string} headerId
454 * @return {boolean} 454 * @return {boolean}
455 */ 455 */
456 _removeCustomHeader(headerId) { 456 _removeCustomHeader(headerId) {
457 headerId = headerId.toLowerCase(); 457 headerId = headerId.toLowerCase();
458 var index = this._columns.findIndex(columnConfig => columnConfig.id === head erId); 458 var index = this._columns.findIndex(columnConfig => columnConfig.id === head erId);
459 if (index === -1) 459 if (index === -1)
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 /** 805 /**
806 * @enum {string} 806 * @enum {string}
807 */ 807 */
808 Network.NetworkLogViewColumns.WaterfallSortIds = { 808 Network.NetworkLogViewColumns.WaterfallSortIds = {
809 StartTime: 'startTime', 809 StartTime: 'startTime',
810 ResponseTime: 'responseReceivedTime', 810 ResponseTime: 'responseReceivedTime',
811 EndTime: 'endTime', 811 EndTime: 'endTime',
812 Duration: 'duration', 812 Duration: 'duration',
813 Latency: 'latency' 813 Latency: 'latency'
814 }; 814 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698