Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/extensions/api/dial/dial_api.cc

Issue 2702503003: [Dial] Refactor DialRegistry and DeviceDescriptionFetcher so they can be used by MediaSinkService (Closed)
Patch Set: resolve code review comments from Derek Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/dial/dial_api.cc
diff --git a/chrome/browser/extensions/api/dial/dial_api.cc b/chrome/browser/extensions/api/dial/dial_api.cc
index 0fd0b9c54004fb439585f009446d87e456c25d28..e97f90fa0b260780ad189b0ce32a5c585dd4c248 100644
--- a/chrome/browser/extensions/api/dial/dial_api.cc
+++ b/chrome/browser/extensions/api/dial/dial_api.cc
@@ -56,8 +56,9 @@ DialRegistry* DialAPI::dial_registry() {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!dial_registry_.get()) {
dial_registry_.reset(new DialRegistry(
- this, TimeDelta::FromSeconds(kDialRefreshIntervalSecs),
+ TimeDelta::FromSeconds(kDialRefreshIntervalSecs),
TimeDelta::FromSeconds(kDialExpirationSecs), kDialMaxDevices));
+ dial_registry_->RegisterObserver(this);
if (test_device_data_) {
dial_registry_->AddDeviceForTest(*test_device_data_);
}
@@ -230,7 +231,7 @@ void DialFetchDeviceDescriptionFunction::MaybeStartFetch(const GURL& url) {
}
device_description_fetcher_ = base::MakeUnique<DeviceDescriptionFetcher>(
- url, Profile::FromBrowserContext(browser_context()),
+ url, Profile::FromBrowserContext(browser_context())->GetRequestContext(),
base::BindOnce(&DialFetchDeviceDescriptionFunction::OnFetchComplete,
this),
base::BindOnce(&DialFetchDeviceDescriptionFunction::OnFetchError, this));

Powered by Google App Engine
This is Rietveld 408576698