Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/browser/extensions/api/dial/dial_registry_unittest.cc

Issue 2702503003: [Dial] Refactor DialRegistry and DeviceDescriptionFetcher so they can be used by MediaSinkService (Closed)
Patch Set: resolve code review comments from Derek Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/api/dial/dial_registry.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/extensions/api/dial/dial_device_data.h" 8 #include "chrome/browser/extensions/api/dial/dial_device_data.h"
9 #include "chrome/browser/extensions/api/dial/dial_registry.h" 9 #include "chrome/browser/extensions/api/dial/dial_registry.h"
10 #include "chrome/browser/extensions/api/dial/dial_service.h" 10 #include "chrome/browser/extensions/api/dial/dial_service.h"
(...skipping 28 matching lines...) Expand all
39 ~MockDialService() override {} 39 ~MockDialService() override {}
40 40
41 MOCK_METHOD0(Discover, bool()); 41 MOCK_METHOD0(Discover, bool());
42 MOCK_METHOD1(AddObserver, void(DialService::Observer*)); 42 MOCK_METHOD1(AddObserver, void(DialService::Observer*));
43 MOCK_METHOD1(RemoveObserver, void(DialService::Observer*)); 43 MOCK_METHOD1(RemoveObserver, void(DialService::Observer*));
44 MOCK_CONST_METHOD1(HasObserver, bool(const DialService::Observer*)); 44 MOCK_CONST_METHOD1(HasObserver, bool(const DialService::Observer*));
45 }; 45 };
46 46
47 class MockDialRegistry : public DialRegistry { 47 class MockDialRegistry : public DialRegistry {
48 public: 48 public:
49 MockDialRegistry(Observer* dial_api, 49 MockDialRegistry(const base::TimeDelta& refresh_interval,
50 const base::TimeDelta& refresh_interval,
51 const base::TimeDelta& expiration, 50 const base::TimeDelta& expiration,
52 const size_t max_devices) 51 const size_t max_devices)
53 : DialRegistry(dial_api, refresh_interval, expiration, max_devices), 52 : DialRegistry(refresh_interval, expiration, max_devices),
54 time_(Time::Now()) {} 53 time_(Time::Now()) {}
55 54
56 ~MockDialRegistry() override { 55 ~MockDialRegistry() override {
57 // Don't let the DialRegistry delete this. 56 // Don't let the DialRegistry delete this.
58 DialService* tmp = dial_.release(); 57 DialService* tmp = dial_.release();
59 if (tmp) 58 if (tmp)
60 CHECK_EQ(&mock_service_, tmp); 59 CHECK_EQ(&mock_service_, tmp);
61 } 60 }
62 61
63 // Returns the mock Dial service. 62 // Returns the mock Dial service.
(...skipping 23 matching lines...) Expand all
87 }; 86 };
88 87
89 class DialRegistryTest : public testing::Test { 88 class DialRegistryTest : public testing::Test {
90 public: 89 public:
91 DialRegistryTest() 90 DialRegistryTest()
92 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP), 91 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
93 first_device_("first", GURL("http://127.0.0.1/dd.xml"), Time::Now()), 92 first_device_("first", GURL("http://127.0.0.1/dd.xml"), Time::Now()),
94 second_device_("second", GURL("http://127.0.0.2/dd.xml"), Time::Now()), 93 second_device_("second", GURL("http://127.0.0.2/dd.xml"), Time::Now()),
95 third_device_("third", GURL("http://127.0.0.3/dd.xml"), Time::Now()) { 94 third_device_("third", GURL("http://127.0.0.3/dd.xml"), Time::Now()) {
96 registry_ = base::MakeUnique<MockDialRegistry>( 95 registry_ = base::MakeUnique<MockDialRegistry>(
97 &mock_observer_, TimeDelta::FromSeconds(1000), 96 TimeDelta::FromSeconds(1000), TimeDelta::FromSeconds(10), 10);
98 TimeDelta::FromSeconds(10), 10); 97 registry_->RegisterObserver(&mock_observer_);
99 list_with_first_device_.push_back(first_device_); 98 list_with_first_device_.push_back(first_device_);
100 list_with_second_device_.push_back(second_device_); 99 list_with_second_device_.push_back(second_device_);
101 } 100 }
102 101
103 protected: 102 protected:
104 void SetListenerExpectations() { 103 void SetListenerExpectations() {
105 EXPECT_CALL(registry_->mock_service(), 104 EXPECT_CALL(registry_->mock_service(),
106 AddObserver(A<DialService::Observer*>())); 105 AddObserver(A<DialService::Observer*>()));
107 EXPECT_CALL(registry_->mock_service(), 106 EXPECT_CALL(registry_->mock_service(),
108 RemoveObserver(A<DialService::Observer*>())); 107 RemoveObserver(A<DialService::Observer*>()));
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 registry_->OnDiscoveryRequest(nullptr); 373 registry_->OnDiscoveryRequest(nullptr);
375 registry_->OnDeviceDiscovered(nullptr, third_device_); 374 registry_->OnDeviceDiscovered(nullptr, third_device_);
376 registry_->OnDiscoveryFinished(nullptr); 375 registry_->OnDiscoveryFinished(nullptr);
377 376
378 registry_->OnListenerRemoved(); 377 registry_->OnListenerRemoved();
379 } 378 }
380 379
381 } // namespace dial 380 } // namespace dial
382 } // namespace api 381 } // namespace api
383 } // namespace extensions 382 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/dial/dial_registry.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698