third_party/WebKit/Source/core/loader/FrameLoader.h - Issue 2702503002: Block renderer-initiated main frame navigations to data URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.h

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)

Patch Set: dcheng comments - move checks to FrameLoader Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameLoader.h

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.h b/third_party/WebKit/Source/core/loader/FrameLoader.h

index 7d7a0f3a4f6a60d46f78b232587f57d254ec443f..2dee4afad10b21859a4eb7fe426a28d40beb9aee 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.h

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.h

@@ -98,6 +98,7 @@ class CORE_EXPORT FrameLoader final {

HistoryLoadType = kHistoryDifferentDocumentLoad);

static void ReportLocalLoadFailed(LocalFrame*, const String& url);

+ static void ReportTopLevelNavigationFailed(LocalFrame*, const String& url);

// Warning: stopAllLoaders can and will detach the LocalFrame out from under

// you. All callers need to either protect the LocalFrame or guarantee they