content/renderer/render_frame_impl.h - Issue 2702503002: Block renderer-initiated main frame navigations to data URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)

Patch Set: dcheng comments - move checks to FrameLoader Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index c9abba4ee9664e600b11f2d905927edb92d27ae4..9a9f1a2e3c22eb2a632242736a8fac39c611da75 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -653,6 +653,8 @@ class CONTENT_EXPORT RenderFrameImpl

blink::WebString UserAgentOverride() override;

blink::WebString DoNotTrackValue() override;

bool AllowWebGL(bool default_value) override;

+ bool AllowContentInitiatedDataUrlNavigations(

+ const blink::WebURL& url) override;

blink::WebScreenOrientationClient* GetWebScreenOrientationClient() override;

void PostAccessibilityEvent(const blink::WebAXObject& obj,

blink::WebAXEvent event) override;