chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java - Issue 2702503002: Block renderer-initiated main frame navigations to data URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)

Patch Set: dcheng comments - move checks to FrameLoader Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc ('k') | chrome/test/data/android/popup_test.html » ('j') | content/browser/frame_host/data_url_navigation_throttle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java

diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java

index 248cbc47ef1ce152fe349ecd21278060d6ec3a63..ea3744cb63e1a6e46655c753f945431d19e34275 100644

--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java

+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java

@@ -80,8 +80,7 @@ public abstract class MultiActivityTestBase extends InstrumentationTestCase

/** Clicking the body triggers a window.open() call to open URL_4. */

protected static final String SUCCESS_URL = UrlUtils.encodeHtmlDataUri("opened!");

- protected static final String ONCLICK_LINK = UrlUtils.encodeHtmlDataUri(

- "<html>"

+ protected static final String ONCLICK_LINK = UrlUtils.encodeHtmlDataUri("<html>"

+ " <head>"

+ " <title>window.open page</title>"

+ " <meta name='viewport'"

@@ -91,8 +90,11 @@ public abstract class MultiActivityTestBase extends InstrumentationTestCase

+ " </style>"

+ " <script>"

+ " function openNewWindow() {"

- + " var site = window.open('" + URL_4 + "');"

- + " if (site) location.href = '" + SUCCESS_URL + "';"

+ + " var site = window.open('about:blank');"

+ + " if (site) {"

+ + " site.document.write('" + URL_4 + "');"

+ + " location.href = '" + SUCCESS_URL + "';"

+ + " }"

+ " }"

+ " </script>"

+ " </head>"