Block renderer-initiated main frame navigations to data URLs

third_party/WebKit/Source/platform/network/NetworkUtils.cpp

Index: third_party/WebKit/Source/platform/network/NetworkUtils.cpp
diff --git a/third_party/WebKit/Source/platform/network/NetworkUtils.cpp b/third_party/WebKit/Source/platform/network/NetworkUtils.cpp
index f5e93f1e25675e1a3f1a32e084aa7697fb51726a..d728be05f44004791f96e10a85eb993c646f7e80 100644
--- a/third_party/WebKit/Source/platform/network/NetworkUtils.cpp
+++ b/third_party/WebKit/Source/platform/network/NetworkUtils.cpp
@@ -105,6 +105,19 @@ PassRefPtr<SharedBuffer> parseDataURLAndPopulateResponse(
   return data;
 }
 
+PLATFORM_EXPORT bool getDataURLMimeType(const KURL& url,
+                                        AtomicString& mimetype,
+                                        bool* isSupportedMimeType) {

[dcheng, 2017/04/12 23:51:24]

Nit: please update the naming style to be GetDataURLMimeType(const KURL& url,
..., bool* is_supported_mime_type) {

Same elsewhere. Also, standard Blink convention would be to pass the bool
argument by reference here, though I think in this case, we don't need the extra
parameter and can just use the return value directly? e.g. make this

if (net::DataURL::Parse(...))
  return mime_util::IsSupportedMimeType(...);
return false;

[meacer, 2017/04/13 18:06:36]

Done.
It sounds like you prefer this to be renamed to IsDataURLMimeTypeSupported() or
something similar? Or I can move all this into SecurityOrigin.cpp since that's
the only place calling this method.

[kinuko, 2017/04/14 14:29:53]

We're neither populating the mime_type nor using it in the call site, are we? 
If not I think just making this IsDataURLMimeTypeSupported() makes more sense.
I prefer having this here so that we don't need to add mime_util code / DEPS
scattered around.

[meacer, 2017/04/14 17:51:19]

Yes, I copied this over from net and missed that param. It now simply takes a
url and returns a bool.
Sure, keeping here.

+  std::string utf8MimeType;
+  std::string utf8Charset;
+  if (net::DataURL::Parse(WebStringToGURL(url.getString()), &utf8MimeType,
+                          &utf8Charset, nullptr)) {
+    *isSupportedMimeType = mime_util::IsSupportedMimeType(utf8MimeType);
+    return true;
+  }
+  return false;
+}
+
 bool isRedirectResponseCode(int responseCode) {
   return net::HttpResponseHeaders::IsRedirectResponseCode(responseCode);
 }