Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)
Patch Set: Re-block data to data navigations, rebase, address nasko comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 4b25c97a1395c02efaa633f8b1ff34ff6d6eb48f..f6a488e26d9ad90a7d092b6fee0ce01e2fb2e129 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4707,6 +4707,12 @@ bool RenderFrameImpl::allowWebGL(bool default_value) {
return !blocked;
}
+bool RenderFrameImpl::allowInsecureDataUrlNavigations(
+ const blink::WebURL& url) {
+ // Error pages can navigate to data URLs.
+ return url.string() == kUnreachableWebDataURL;
nasko 2017/04/05 23:55:19 Given this implementation, naming this method "all
meacer 2017/04/06 01:25:42 Done.
+}
+
blink::WebScreenOrientationClient*
RenderFrameImpl::webScreenOrientationClient() {
if (!screen_orientation_dispatcher_)

Powered by Google App Engine
This is Rietveld 408576698