third_party/WebKit/Source/core/loader/FrameLoader.h - Issue 2702503002: Block renderer-initiated main frame navigations to data URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.h

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)

Patch Set: nasko comments, fix most tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameLoader.h

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.h b/third_party/WebKit/Source/core/loader/FrameLoader.h

index 40ee2b1ab2bd67a003e5de00aacb1f0ca4e34ac1..f33e37b7c446e307c5f7381ac90b03c6a91a41dc 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.h

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.h

@@ -100,6 +100,7 @@ class CORE_EXPORT FrameLoader final {

HistoryLoadType = HistoryDifferentDocumentLoad);

static void reportLocalLoadFailed(LocalFrame*, const String& url);

+ static void reportTopLevelNavigationFailed(LocalFrame*, const String& url);

// Warning: stopAllLoaders can and will detach the LocalFrame out from under

// you. All callers need to either protect the LocalFrame or guarantee they