third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html - Issue 2702503002: Block renderer-initiated main frame navigations to data URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)

Patch Set: nasko comments, fix most tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/navigation_handle.h ('K') | « third_party/WebKit/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html b/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html

index 7ffb936edb8f003702cae064c151263fa2c72b46..b60f45d31d4041e5a0ae79874cc466c11897d71e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html

+++ b/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate.html

@@ -7,11 +7,11 @@ if (window.testRunner) {

}

</script>

<p>To run this test outside of DumpRenderTree, please disable your popup blocker!</p>

-<p>This test passes if it doesnt hang.</p>

+<p>This test passes if it doesn't hang.</p>

src="data:text/html,

- var win = window.open('data:text/html,', '_blank');

- win.location = 'http://127.0.0.1:8000/navigation/resources/pass-and-notify-done.html';

+ var win = window.open('about:blank', '_blank');

+ win.location = 'http://127.0.0.1:8000/navigation/resources/pass-and-notify-done.html';

</script>"

></iframe>