extensions/test/data/web_view/apitest/guest_data_url.html - Issue 2702503002: Block renderer-initiated main frame navigations to data URLs - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1756)

My Issues | Starred Open | Closed | All

Unified Diff: extensions/test/data/web_view/apitest/guest_data_url.html

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)

Patch Set: nasko comments, fix most tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« content/public/browser/navigation_handle.h ('K') | « extensions/test/data/web_view/apitest/guest.html ('k') | extensions/test/data/web_view/apitest/guest_noreferrer.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/test/data/web_view/apitest/guest_data_url.html

diff --git a/extensions/test/data/web_view/apitest/guest.html b/extensions/test/data/web_view/apitest/guest_data_url.html

similarity index 60%

copy from extensions/test/data/web_view/apitest/guest.html

copy to extensions/test/data/web_view/apitest/guest_data_url.html

index f893348671a20cf7e6938b5a281fc7ffa881892d..b7a228274f989beb40cfd5de33ec0cd6708e6bef 100644

--- a/extensions/test/data/web_view/apitest/guest.html

+++ b/extensions/test/data/web_view/apitest/guest_data_url.html

@@ -1,6 +1,6 @@

<!doctype html>

<!--

- * Copyright (c) 2013 The Chromium Authors. All rights reserved. Use of this

+ * Copyright (c) 2017 The Chromium Authors. All rights reserved. Use of this

* source code is governed by a BSD-style license that can be found in the

* LICENSE file.

-->

@@ -8,10 +8,8 @@

<head>

<title>A guest that opens a new window.</title>

<script type="text/javascript">

- window.onload = function() {

- window.open(

- 'data:text/html,<html><body>Initial dummy guest</body></html>');

- };

+ window.location.href =

+ "data:text/html,<html><body>Initial dummy guest</body></html>";

</script>

</head>

<body style="padding: 0; margin: 0;">

« content/public/browser/navigation_handle.h ('K') | « extensions/test/data/web_view/apitest/guest.html ('k') | extensions/test/data/web_view/apitest/guest_noreferrer.html » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698