Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)
Patch Set: nasko comments, fix most tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index c3c3fa73f859706e237d986e0e520be77c31fb6b..b3a906f37dd2f60dd0164b787f88e430469d9bbf 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -131,6 +131,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
RenderFrameHostImpl* GetRenderFrameHost() override;
bool IsSameDocument() override;
bool HasCommitted() override;
+ bool IsDownload() override;
nasko 2017/03/30 23:15:45 This will move down and become is_download(), sinc
meacer 2017/04/05 22:33:28 By move down I assume you mean move away from the
bool IsErrorPage() override;
bool HasSubframeNavigationEntryCommitted() override;
bool DidReplaceEntry() override;

Powered by Google App Engine
This is Rietveld 408576698