Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/shim/main.js

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)
Patch Set: nasko comments, fix most tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/platform_apps/web_view/shim/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
index dfedddcd7315d03324beb360b30cdeeb9ec1b699..473d81db7217e6818d28711508090b5235a7fe82 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
@@ -1313,7 +1313,7 @@ function testExecuteScriptIsAbortedWhenWebViewSourceIsChanged() {
webview.addEventListener('loadstop', function onLoadStop(e) {
window.console.log('2. Inject script to trigger a guest-initiated ' +
'navigation.');
- var navUrl = 'data:text/html,trigger nav';
+ var navUrl = 'data:text/html, trigger nav';
webview.executeScript({
code: 'window.location.href = "' + navUrl + '";'
});
@@ -1321,7 +1321,7 @@ function testExecuteScriptIsAbortedWhenWebViewSourceIsChanged() {
window.console.log('3. Listening for the load that will be started as a ' +
'result of 2.');
webview.addEventListener('loadstart', function onLoadStart(e) {
- embedder.test.assertEq('about:blank', webview.src);
+ embedder.test.assertEq('data:text/html, initial page', webview.src);
window.console.log('4. Attempting to inject script into about:blank. ' +
'This is expected to fail.');
webview.executeScript(
@@ -1340,7 +1340,7 @@ function testExecuteScriptIsAbortedWhenWebViewSourceIsChanged() {
});
window.console.log('1. Performing initial navigation.');
- webview.setAttribute('src', 'about:blank');
+ webview.setAttribute('src', 'data:text/html, initial page');
document.body.appendChild(webview);
}

Powered by Google App Engine
This is Rietveld 408576698