chrome/test/data/android/popup_test.html - Issue 2702503002: Block renderer-initiated main frame navigations to data URLs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/android/popup_test.html

Issue 2702503002: Block renderer-initiated main frame navigations to data URLs (Closed)

Patch Set: dcheng comments - move checks to FrameLoader Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>Popup test page</title>	3 <title>Popup test page</title>

4 <script type="text/javascript">	4 <script type="text/javascript">

5 function spawnWindows() {	5 function spawnWindows() {

6 window.open('data:text/html,<html><head><title>Popup #1</title></head><b ody /></html>');	6 window.open('navigate/one.html');

7 window.open('data:text/html,<html><head><title>Popup #2</title></head><b ody /></html>');	7 window.open('navigate/two.html');

8 window.open('data:text/html,<html><head><title>Popup #3</title></head><b ody /></html>');	8 window.open('navigate/three.html');

9 }	9 }

10 </script>	10 </script>

11 </head>	11 </head>

12 <body onload="spawnWindows()">	12 <body onload="spawnWindows()">

13 Spawning three popup windows...	13 Spawning three popup windows...

14 </body>	14 </body>

15 </html>	15 </html>

OLD	NEW