[ash-md] Disables the Wi-Fi and Cellular toggles until the state changes

ash/common/system/chromeos/bluetooth/tray_bluetooth.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/chromeos/bluetooth/tray_bluetooth.h"
 
 #include "ash/common/session/session_state_delegate.h"
 #include "ash/common/system/tray/hover_highlight_view.h"
 #include "ash/common/system/tray/system_tray.h"
 #include "ash/common/system/tray/system_tray_delegate.h"
@@ skipping 248 matching lines @@
                                            new_connected_devices);
     RemoveObsoleteBluetoothDevicesFromList(&paired_not_connected_devices_,
                                            new_paired_not_connected_devices);
     RemoveObsoleteBluetoothDevicesFromList(&discovered_not_paired_devices_,
                                            new_discovered_not_paired_devices);
   }
 
   void UpdateHeaderEntry() {
     bool is_bluetooth_enabled =
         WmShell::Get()->system_tray_delegate()->GetBluetoothEnabled();
-    if (toggle_)
-      toggle_->SetIsOn(is_bluetooth_enabled, false);
+    if (!toggle_)
+      return;
+    toggle_->SetEnabled(true);
+    toggle_->SetIsOn(is_bluetooth_enabled, false);
   }
 
   void UpdateDeviceScrollList() {
     device_map_.clear();
     scroll_content()->RemoveAllChildViews(true);
 
     SystemTrayDelegate* delegate = WmShell::Get()->system_tray_delegate();
     bool bluetooth_enabled = delegate->GetBluetoothEnabled();
     bool bluetooth_available = delegate->GetBluetoothAvailable();
 
@@ skipping 162 matching lines @@
     const std::string device_id = find->second;
     if (FoundDevice(device_id, connecting_devices_, nullptr, nullptr))
       return;
 
     UpdateClickedDevice(device_id, view);
     delegate->ConnectToBluetoothDevice(device_id);
   }
 
   void HandleButtonPressed(views::Button* sender,
                            const ui::Event& event) override {
-    if (sender == toggle_)
+    if (sender == toggle_) {
+      // Disable the toggle to prevent bouncing. It will get re-enabled when

[tdanderson, 2017/02/28 16:30:03]

nit: Perhaps be a bit more specific with what is meant by 'bouncing' - maybe say
something like "In the event of multiple clicks within a short period of time,
helps to prevent a toggle button appearance becoming inconsistent with the async
operation of enabling/disabling Bluetooth" or similar but more condensed?

Ditto for the comment in network_list_md

[varkha, 2017/03/08 01:45:35]

Done (in network_list_md.cc).

+      // BluetoothDetailedView::Update() gets called.
+      toggle_->SetEnabled(false);
       WmShell::Get()->system_tray_delegate()->ToggleBluetooth();
-    else if (sender == settings_)
+    } else if (sender == settings_) {
       ShowSettings();
-    else
+    } else {
       NOTREACHED();
+    }
   }
 
   void CreateExtraTitleRowButtons() override {
     if (login_ == LoginStatus::LOCKED)
       return;
 
     DCHECK(!toggle_);
     DCHECK(!settings_);
 
     tri_view()->SetContainerVisible(TriView::Container::END, true);
@@ skipping 149 matching lines @@
     detailed_->Update();
 }
 
 void TrayBluetooth::OnBluetoothDiscoveringChanged() {
   if (!detailed_)
     return;
   detailed_->Update();
 }
 
 }  // namespace ash