third_party/WebKit/LayoutTests/animations/sample-on-last-keyframe.html - Issue 2702483002: Paint some content for animated elements in composited animation tests.

Unified Diff: third_party/WebKit/LayoutTests/animations/sample-on-last-keyframe.html

Issue 2702483002: Paint some content for animated elements in composited animation tests. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js ('k') | third_party/WebKit/LayoutTests/animations/zoom-responsive-transform-animation.html » ('j') | third_party/WebKit/LayoutTests/animations/zoom-responsive-transform-animation.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/animations/sample-on-last-keyframe.html

diff --git a/third_party/WebKit/LayoutTests/animations/sample-on-last-keyframe.html b/third_party/WebKit/LayoutTests/animations/sample-on-last-keyframe.html

index 7c7cc27675b636e169566cf036004508fb0b518d..d4370e9b82b8a859875d27f2882cdd93b19bdb7a 100644

--- a/third_party/WebKit/LayoutTests/animations/sample-on-last-keyframe.html

+++ b/third_party/WebKit/LayoutTests/animations/sample-on-last-keyframe.html

@@ -34,7 +34,7 @@

</head>

<body>

<p>Tests sampling a keyframe animation on the last keyframe.</p>

-<div id="test"></div>

+<div id="test">x</div>

alancutter (OOO until 2018) 2017/02/16 01:12:30 This test doesn't depend on the animation being co

wkorman 2017/02/17 21:42:31 This test hangs when run in SPv2 via: 1. comment

alancutter (OOO until 2018) 2017/02/20 00:18:30 I consider this test failing as an indication that

wkorman 2017/02/23 21:36:58 I see what you're saying, but let me make sure I u

I see what you're saying, but let me make sure I understand what you're thinking. So once we fix 692310, for SPv2, this test as currently written will cease to consider this animation a composited animation when run as virtual/threaded/animations/sample-on-last-keyframe.html, because it paints no content and so has no layer. But isn't the intent of having this test included under the virtual/threaded test suite to ensure that this case (on last keyframe, the opacity is what we expect, within some tolerance) runs correctly as both a composited and non-composited animation? And so once we have "fixed" 692310, unless we modify this test to paint some content, it will essentially be running as a non-composited animation even when run under virtual/threaded. So it doesn't seem to me like it would then be testing what it's aiming to test. But I am quite likely missing something.

</div>

</body>